Spin-off issue from #3042774-18: Drupal 9 Deprecated Code Report

Several Feed classes implement ConfigurablePluginInterface. These should be replaced with ConfigurableInterface and possibly DependentPluginInterface.

Fetching class constant class of deprecated class Drupal​\​Component​\​Plugin​\​ConfigurablePluginInterface:
Drupal​\​Component​\​Plugin​\​ConfigurablePluginInterface is deprecated
in Drupal 8.7.0 and will be removed before Drupal 9.0.0. You should implement
ConfigurableInterface and/or DependentPluginInterface directly as needed. If
you implement ConfigurableInterface you may choose to implement
ConfigurablePluginInterface in Drupal 8 as well for maximum compatibility,
however this must be removed prior to Drupal 9.

Patch will follow.

Comments

MegaChriz created an issue. See original summary.

megachriz’s picture

Status: Active » Needs review
StatusFileSize
new2.58 KB

I'm not sure yet if DependentPluginInterface should be added everywhere. Also I need to check if ConfigurablePluginInterface should perhaps still be used at some places.

megachriz’s picture

megachriz’s picture

StatusFileSize
new3.06 KB
new1.04 KB

Okay, I inspected the code and I think it will be best for action plugins to check for both ConfigurableInterface and ConfigurablePluginInterface.

There are also deprecated actions listed that would need to be removed from the list. This would also require a database update. I'll open a new issue for that.

  • MegaChriz committed 1fc1f24 on 8.x-3.x
    Issue #3093515 by MegaChriz: Replaced deprecated...
megachriz’s picture

Status: Needs review » Fixed

Committed #4.

kristen pol’s picture

Issue tags: +Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.