Spin-off issue from #3042774-18: Drupal 9 Deprecated Code Report
The class FeedHandlerBase extends the deprecated EntityHandlerBase class. FeedHandlerBase should no longer extend this class and take over relevant parts from EntityHandlerBase, which is in case of Feeds only the traits StringTranslationTrait and DependencySerializationTrait. The module handler is not used by any classes that extend FeedHandlerBase, at least not in the Feeds module.
Class Drupal\feeds\FeedHandlerBase extends deprecated class Drupal\Core\Entity\EntityHandlerBase. Deprecated in Drupal 8.0.x, will be removed before Drupal 9.0.0.
Implement the container injection pattern of
\Drupal\Core\Entity\EntityHandlerInterface::createInstance() to obtain the
module handler service for your class.
Patch will follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | feeds-replace-EntityHandlerBase-3093512-2.patch | 1.24 KB | megachriz |
Comments
Comment #2
megachrizComment #4
megachrizOkay, tests still pass. I think the tests in #3042774-18: Drupal 9 Deprecated Code Report because I forgot DependencySerializationTrait there.
Committed #2.
Comment #5
megachrizComment #7
kristen polPer a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.