Closed (fixed)
Project:
Drupal core
Version:
9.0.x-dev
Component:
content_moderation.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Nov 2019 at 11:27 UTC
Updated:
12 Dec 2019 at 12:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
amateescu commentedThis should do it.
Comment #4
sam152 commentedHm, I spun out #3093132: Remove isLatestRevision, getLatestRevision, getLatestRevisionId from the ModerationInformation service and #3088748: Remove the deprecated views relationship provided by content moderation to the internal ContentModerationState entity type. I don't mind combining these if it's easier, but I would have imagined smaller issues would have been easier to commit.
Comment #5
dinesh18 commentedI have looked into the two tickets mentioned and it looks good to me. But we still have some more deprecated methods which we need to remove.
Attached is the screenshot after applying the patches mentioned in #4.
Agree with @Sam152 smaller issues would be easier to commit.
Comment #6
berdir> Agree with @Sam152 smaller issues would be easier to commit.
Looking at the parent, one issue per module/component seems to be better standard. Some are smaller but several are just as big or bigger. I think these removal only issues are pretty easy to review, you just need one check per file/function to make sure it really should be removed.
Comment #7
longwaveRerolled and included remaining deprecations.
Comment #8
sam152 commentedIf large issues are being committed, I'm fine with it here too.
Comment #10
catchJust to say for deprecation removals, especially when the diffstat is like this
16 files changed, 4 insertions, 1163 deletions., per-module seems the best way. Very little chance of conflicting with other deprecation removal patches (and most other patches shouldn't touch already-deprecated code either).If we have actual bc-layer logic that's not simply a case of removing hunks of code it might be worth splitting out sometimes.
Committed 6c69385 and pushed to 9.0.x. Thanks!
Comment #11
wim leersClosed #3088748: Remove the deprecated views relationship provided by content moderation to the internal ContentModerationState entity type as outdated since this patch was a superset of that one.