AddToCalendar config does not match schema, plus some schema missing

This patch works to make the display text translatable, but unfortunately the list of calendars to show in the button doesn't get saved anymore. No calendars are selected.

Please have a look at my below patch and screenshots.

Steps to test 'Add to calendar' Button:

 
1. Before,applying this patch uninstall this module and apply it

   

2. Then re-install the module again

   

3. Add to calendar field is added and add this field in any of your cck. In field settings check the 'Google calender' checkbox.

   

4. Then add a sample content and check the checkbox 'Show add to calendar widget' and save it

   

5. You can able to see the 'Add to calendar' button in your node

Please let me know if you are facing any issues

Hi,

I have tested the patch it is working for me.

@ramya thanks for the steps. same am following its work for me.

Also need to provide schema for provided Third party settings for date formatters

cause currently I got missing schema error

I just added some basic functional test coverage in #3379744: Addtocalendar could use some automated tests! that should be helpful in resolving this issue.

I added protected $strictConfigSchema = FALSE; to the test because indeed there are schema problems in the module. If I remove that declaration and run the test it fails with:

Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for addtocalendar.settings with the following errors: addtocalendar.settings:addtocalendar_show variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\StringData

There are other schema problems as well, as the IS notes.

Anyway, now that we have automated tests, the goal of this issue is to get those tests to run after removing the $strictConfigSchema declaration.

I just applied the patch in #6 and ran the test locally with the strict schema enforced. I got a little farther I think before the test failed for a schema violation:

1) Drupal\Tests\addtocalendar\Functional\AddToCalendarTest::testAddToCalendarFormatter
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for field.field.node.page.field_addtocalendar with the following errors: field.field.node.page.field_addtocalendar:settings.addtocalendar_settings.data_calendars.iCalendar variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\StringData, field.field.node.page.field_addtocalendar:settings.addtocalendar_settings.data_calendars.Outlook Online variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\StringData, field.field.node.page.field_addtocalendar:settings.addtocalendar_settings.data_calendars.Yahoo! Calendar variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\StringData

So that's one thing that needs fixing. That needs to be string though, so we'll need to update the config in the test module. I think technically that indicates we should include an update hook to force that config update on existing sites.

When I update my zeros to '0' in the test config, the tests pass! Yay!

But I also think that field.field_settings.add_to_calendar_field should extend the core boolean schema since our field extends that field.

I'll make both of these updates.

Regarding #10 I think we should handle that in a new issue since the current test coverage does not cover that case.

Here's an updated patch with everything mentioned in #12.

Fixed!

Thank you for the nice work, @kaythay! I noticed that the patch in #6 is simply a re-posted version of your original patch in #2.

I created a followup for the third party settings: #3379787: AddToCalendar third party settings missing schema