The D9 release plan for Smart Trim is:

Wait until core 8.8.0 is released.
Start fixing 9.x compatibility bugs in sub-issues, not in this one.
Aim to have a release of Smart Trim that is fully compatible with 8.x and 9.x the day that 9.0 is released.
This seems generic because the upgrade from D8 to D9 will be pretty generic for the vast majority of modules.

CommentFileSizeAuthor
#4 smart_trim-n3092581-4.patch411 bytesdamienmckenna
#3 3092581-smart_trim-drupal-9.patch257 bytesmarkie

Comments

markie created an issue. See original summary.

jenlampton’s picture

jenlampton
she / her
commented

Are there any sub-issues other than https://www.drupal.org/project/smart_trim/issues/3042672?

markie’s picture

markie commented
Status: Active » Needs review
StatusFileSize
new 3092581-smart_trim-drupal-9.patch257 bytes

I think the only thing that needs to happen still is adding the `core_version_requirement: ^8 || ^9` into the info.yml.. which the following patch does.. I tested this in the latest dev version of d9 and the module works. Please test and tell me differently (if you find it)

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new smart_trim-n3092581-4.patch411 bytes

You should remove the "core" line too.

markie’s picture

markie commented
Status: Needs review » Reviewed & tested by the community

I applied the #4 patch and tested locally. Anyone else want to give it a try, or I'll commit it later.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented

Hi @markie - I think you need to commit #3 because of these two change records - https://www.drupal.org/node/3119415 & https://www.drupal.org/node/3070687
As mentioned in the change records -
This specifies that the module is compatible with all versions of Drupal 8 and 9. The core:is required here because Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.

If this module is only compatible with greater then drupal core 8.7.7 then -
The core: key must not be used here to make sure that versions of Drupal before 8.7.7 will not install the module. Adding both core and core_version_requirement with anything other than core_version_requirement: ^8 || ^9 will result in an exception.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@yogeshmpawar: While technically correct, if a site hasn't updated to 8.7.7 since its release last September their site is vulnerable to bugs fixed in 8.7.11 and 8.7.12, so I don't think maintainers should make too much of a fuss.

  • markie committed f7e884f on 8.x-1.x authored by DamienMcKenna 
    Issue #3092581 by jenlampton, DamienMcKenna: Drupal 9 Release plan for...
markie’s picture

markie commented
Status: Reviewed & tested by the community » Fixed

Merged #4. Thanks for your help

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented

@DamienMcKenna - Agreed on your comments. Thanks

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

To qualify for the DrupalCares challenge, there needs to be a new release of the module that is D9 compatible. Deadline is today :) The info file was updated in this issue and #3042672: Drupal 9 Deprecated Code Report is fixed so is there any reason not to tag a release?

UPDATED: You probably want to update your issue credit checkboxes too because I see Jen was credited in the commit but not as an issue credit.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Chatted with @markie in Slack and there is a regression to be dealt with before making a new release. I'll make a new issue for specifically this task because this issue is already marked fixed.

UPDATED: I added an explicit ticket for both the release and the project page update: https://www.drupal.org/project/smart_trim/issues/3132567

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.