Closed (fixed)
Project:
Password Policy
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
5 Nov 2019 at 04:04 UTC
Updated:
2 Jun 2022 at 20:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
omkar06 commentedComment #3
omkar06 commentedAdding a basic fix to handle SSO based users. Please review and share if there any better approach to handle it.
Comment #4
omkar06 commentedComment #5
omkar06 commentedComment #6
omkar06 commentedComment #7
aohrvetpv commentedThanks for the feature request and patch! Password Policy 7.x-1.x and 7.x-2.x have a feature that allows excluding selected authentication modules from password policies. Here is some of the code from 7.x-1.x:
https://git.drupalcode.org/project/password_policy/blob/7.x-1.x/password...
I think we should probably implement this in 8.x-3.x.
So I think your patch is the right idea, but that we shouldn't have any code specific to "simpleSAMLphp Authentication" in Password Policy, so we can accommodate all the many other authentication modules like "simpleSAMLphp Authentication".
Comment #8
aohrvetpv commentedIt might be reasonable to commit code specific to that module (simpleSAMLphp Authentication) until we can implement the more general solution. Later we would just drop the module-specific code.
Comment #9
manish.upadhyay commentedPatch for https://www.drupal.org/project/password_policy/releases/8.x-3.0-beta1 release.
Comment #10
simbaw commentedMake all SSO users skip password policy.
Comment #11
simbaw commentedComment #12
rosk0Thanks for the idea @simbaw. I've used your approach, but improved implementation a bit.
Changes are :
Comment #13
rosk0Correct interdiff for the previous comment.
Comment #14
rosk0Battle tested the patch from #12 - works like a charm! Thanks @simbaw - all credits should go there.
Comment #16
paulocsThanks!
Comment #17
paulocs