Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Once the sortable library is in 8.8 and we can rely on it to exist on testbot, we should use that.
Comment | File | Size | Author |
---|---|---|---|
#7 | paragraphs-3090457-7.patch | 2.11 KB | bartlangelaan |
| |||
#5 | paragraphs-3090457-5.patch | 2.38 KB | bartlangelaan |
|
Comments
Comment #2
BerdirBlocked on #3064049: Replace jQuery UI sortable with Sortable js, once that is in we can start with a patch to test it.
Comment #3
Martijn de Wit#3064049: Replace jQuery UI sortable with Sortable js is in Drupal > 8.8.x 🙌
Comment #4
bartlangelaanThis patch adds
core/sortable
as a library dependency tocore/paragraphs-dragdrop
. Whencore/sortable
is not available (8.7 or older), the old behaviour is invoked.This means that from 8.8 onwards, the core version of sortable is always used.
Because this change makes the drag-and-drop functionality work out-of-the-box with Drupal 8.8+, can we maybe split this issue up and create tests in a separate issue? This patch doen't change and/or improve anything on a functional level.
Comment #5
bartlangelaanComment #6
Berdirshort if syntax isn't allowed in the drupal coding standard.
Lets do this with a version check, that should be easier, this almost recursively discovers libraries which is a bit scary:
For tests, lets make a deal, you create a follow-up to add test coverage and then I'll commit it without ;)
Comment #7
bartlangelaanSee adjusted patch.
I adjusted the issue title & summary. Also, created a follow-up: #3099706: Add JS test coverage for drag and drop.
Comment #8
bartlangelaanComment #9
BerdirTested that in our project, works well. And once we require 8.8 we can just remove all that code. Also updated the README.txt a bit.