Steps to reproduce:

  • Enable translation to media type image.
  • Enable media entities in sitemap settings
  • Enable indexing for media type image.
  • Add media content and it's translations.

In the generated sitemap, under the images column. The original content's image URLs are shown multiple times. Expected result is to get the URLs of original and the translation content's images.

CommentFileSizeAuthor
#6 images_of_translated_entities_3090118_4.patch2.35 KBs_bhandari
#3 images_of_translated_entities.patch2.29 KBshashikanth171
#2 images_of_translated_entities.patch1.18 KBshashikanth171

Comments

shashikanth171 created an issue. See original summary.

shashikanth171’s picture

shashikanth171 commented
StatusFileSize
new images_of_translated_entities.patch1.18 KB

This patch applies only when all the images on the website are added via media library.

shashikanth171’s picture

shashikanth171 commented
StatusFileSize
new images_of_translated_entities.patch2.29 KB

With the previous patch there are unknown field 'image' errors. Attaching updated patch.

gbyte’s picture

gbyte
Location Berlin
commented
Status: Needs review » Postponed (maintainer needs more info)

Thanks for the patch. Right now this module barely supports media image indexation, hence this issue: #2987748: Add Media images to sitemap. Would you care to explain what exactly you are doing when indexing media entities? What is the desired outcome (what type of sitemap standard are you getting out of it)? Also please take a screenshot or provide a link to the sitemap.

Regarding the patch itself, would

if ($entity->hasTranslation($langcode)) {
  //...
}

not prevent the indexation if there is no translation?

gbyte’s picture

gbyte
Location Berlin
commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

Closing due to lack of activity.

s_bhandari’s picture

s_bhandari commented
Status: Closed (works as designed) » Needs review
StatusFileSize
new images_of_translated_entities_3090118_4.patch2.35 KB

Hi,

The last patch is not getting applied on the latest version. Hence, re-rolled the patch. Please review.

Thanks.

gbyte’s picture

gbyte
Location Berlin
commented
Status: Needs review » Closed (works as designed)

3.x is unsupported, please test 4.x and tag the issue accordingly if needed. Reverting the issue status.