Problem/Motivation

The \Drupal\tfa\Form\SettingsForm contains form action elements that are supplied by its base implementation in \Drupal\Core\Form\ConfigFormBase.

Proposed resolution

Reuse the form action elements from \Drupal\Core\Form\ConfigFormBase for a more consistent configuration experience for site builders.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

The TFA settings form uses a form structure that is consistent with other configuration forms in Drupal.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 3089904-2.patch3.41 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new 3089904-2.patch3.41 KB

Attached patch implements the following changes:

  1. Removes the duplicate StringTranslationTrait
  2. Reuses the form actions elements supplied by \Drupal\Core\Form\ConfigFormBase
  3. Removes the resetForm() method that is no longer called after #2935218: Reset button on TFA Settings form has a problematic UX
  4. Fixes some typos and docblocks

Note: patch applies correctly after #3089880: Link to 'Add encryption profile' page when no encryption profiles are configured

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

  • idebr authored abf28db on 8.x-1.x 
    Issue #3089904 by idebr, jcnventura: Reuse default Drupal components in...
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

It no longer applied, and I'd already removed validateForm() before, but anything that removes lines of code while keeping the same functionality is an RTBC++ :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.