The libraries yml file has an error in that it defines the value "oembed-frame-video-youtube" twice. The second occurrence should be for vimeo rather then youtube.

CommentFileSizeAuthor
#2 varbase_heroslider_media-3088994-libraries-2.patch461 bytesjayelless

Comments

jlscott created an issue. See original summary.

jayelless’s picture

jayelless commented
StatusFileSize
new varbase_heroslider_media-3088994-libraries-2.patch461 bytes

Patch attached.

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Error in libraries yml file » Fix in libraries yml file

Thank you James for reporting and patching
Will commit for sure.

Just to note that they are no functional use at this time, But they could be used in some custom cases
as we add the script in the media-oembed-iframe--remote-video--varbase-media-hero-slider.html.twig template file, in a way so that it will switch by provider for the (nested iframe in iframe in iframe )

<!DOCTYPE html>
<html>
  <head>
    <style>
      iframe {
        position: absolute;
        left: 0;
        top: 0;
        right: 0;
        bottom: 0;
        margin: 0;
        height: 100%;
        width: 100%;
      }
    </style>
    <script src="{{ base_path }}{{ varbase_heroslider_media_path }}/js/oembed-frame.heroslider.{{ provider }}.js"></script>
  </head>
  <body style="margin: 0">
    {{ media|raw }}
  </body>
</html>
rajab natshah’s picture

rajab natshah
he/him
commented
Title: Fix in libraries yml file » Fix wrong library name in Media Hero Slider libraries yml file

  • RajabNatshah committed 1551407 on 8.x-7.x authored by jlscott 
    Issue #3088994 by jlscott: Fix wrong library name in Media Hero Slider...
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » mohammed j. razem
Status: Active » Needs review
Issue tags: +varbase-8.7.3

Committed Thank you :)

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.