Edit Vimeo js file structure in hero slider to make it work better
and avoid some issues appear when the page takes time to load like the video not autoplay in the first slider swipe.

CommentFileSizeAuthor
#6 Test Varbase hero slider Vimeo Video Slides - after the better refactor change of logic.gif16.8 MBrajab natshah
#2 3088981-edit-vimeo-js-structure.patch4.98 KBfirass.ziedan

Comments

Firass Ziedan created an issue. See original summary.

firass.ziedan’s picture

firass.ziedan
Location Jordan
commented
Status: Active » Needs review
StatusFileSize
new 3088981-edit-vimeo-js-structure.patch4.98 KB
rajab natshah’s picture

rajab natshah
he/him
commented
Title: Edit Vimeo js file structure » Change Vimeo js file structure
rajab natshah’s picture

rajab natshah
he/him
commented
Title: Change Vimeo js file structure » Change Vimeo js file structure in hero slider to make it work better and avoid some issues

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » mohammed j. razem
Issue summary: View changes
Issue tags: +varbase-8.7.3
StatusFileSize
new Test Varbase hero slider Vimeo Video Slides - after the better refactor change of logic.gif16.8 MB

Committed ... Thank you Firas :)
It is a better refactor change of logic.
Fully tested the change of the behaviour

https://youtu.be/Bt_7mTJSUBI

Test Varbase hero slider Vimeo Video Slides after the better refactor change of logic

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.