Remove PhantomJS based testing

9.0.0 is gonna feel so much lighter.

+++ b/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php
@@ -38,27 +34,14 @@ abstract class WebDriverTestBase extends BrowserTestBase {
+    if (!is_subclass_of($this->minkDefaultDriverClass, DrupalSelenium2Driver::class)){
+      throw new \UnexpectedValueException(sprintf("%s has to be an instance of %s", $this->minkDefaultDriverClass, DrupalSelenium2Driver::class));
...
+    $this->minkDefaultDriverArgs = ['chrome', NULL, 'http://localhost:4444'];

I guess it cant be a subclass of itself?

Needs-> review >> Needs->patch

And already needs a reroll.

Needs another reroll, but looks ready to go in then.

Sorry, on the wrong branch, my bad! Thanks @alexpott for the pointer!

This looks ready, all references to phantom are gone.

Needs a reroll.

Committed 5733c62 and pushed to 9.0.x. Thanks!

🍰

Oh, I totally misinterpreted this while working on D9 deprecation, I only thought the base class was deprecated and not the driver itself.

i.e. Looking at the WebDriver base class we could see:

  /**
   * {@inheritdoc}
   *
   * To use a legacy phantomjs based approach, please use PhantomJSDriver::class.
   */
  protected $minkDefaultDriverClass = DrupalSelenium2Driver::class;

which I realise now, only was for BC.

Maybe we can clarify in the CR that the PhantomJS driver has been deprecated and removed as well.

This belongs in the release notes, so tagging accordingly. Remember to tag changes to dependencies at time of commit.