This check was performed against branch 8.x-2.x at commit ca362ad2bc6d005e288b2493077f140e315a862a
------ ------------------------------------------------------------------
Line blazy.install
------ ------------------------------------------------------------------
17 Call to deprecated function libraries_get_path():
Will be removed before a stable Drupal 8 release. Please use the
new library load and managment concepts described at:
https://www.drupal.org/node/2170763
------ ------------------------------------------------------------------
------ ------------------------------------------------------------------
Line blazy.module
------ ------------------------------------------------------------------
109 Call to deprecated function libraries_get_path():
Will be removed before a stable Drupal 8 release. Please use the
new library load and managment concepts described at:
https://www.drupal.org/node/2170763
------ ------------------------------------------------------------------
------ ---------------------------------------------------------------------------------------------
Line src/Plugin/Field/FieldFormatter/BlazyVideoFormatter.php
------ ---------------------------------------------------------------------------------------------
21 Class Drupal\blazy\Plugin\Field\FieldFormatter\BlazyVideoFormatter extends deprecated class
Drupal\blazy\Dejavu\BlazyVideoBase:
for \Drupal\blazy\Plugin\Field\FieldFormatter\BlazyMediaFormatterBase
Will be removed prior to full release. This means Slick Video which depends
on VEF is deprecated for Slick Media at Blazy 8.2.x with core Media only.
------ ---------------------------------------------------------------------------------------------
------ -------------------------------------------------------------------------------------------------------------------------------------
Line tests/src/Traits/BlazyCreationTestTrait.php (in context of class Drupal\Tests\blazy\FunctionalJavascript\BlazyFilterJavaScriptTest)
------ -------------------------------------------------------------------------------------------------------------------------------------
497 Call to deprecated function file_unmanaged_copy(): in Drupal 8.7.0, will be removed before Drupal 9.0.0. Use \Drupal\Core\File\FileSystemInterface::copy(). 546 Call to deprecated function file_unmanaged_save_data(): in Drupal 8.7.0, will be removed before Drupal 9.0.0. Use \Drupal\Core\File\FileSystemInterface::saveData(). 574 Call to deprecated function file_prepare_directory(): in Drupal 8.7.0, will be removed before Drupal 9.0.0. Use \Drupal\Core\File\FileSystemInterface::prepareDirectory(). ------ -------------------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------
Line tests/src/Traits/BlazyCreationTestTrait.php (in context of class Drupal\Tests\blazy\FunctionalJavascript\BlazyJavaScriptTestBase)
------ -----------------------------------------------------------------------------------------------------------------------------------
497 Call to deprecated function file_unmanaged_copy(): in Drupal 8.7.0, will be removed before Drupal 9.0.0. Use \Drupal\Core\File\FileSystemInterface::copy(). 546 Call to deprecated function file_unmanaged_save_data(): in Drupal 8.7.0, will be removed before Drupal 9.0.0. Use \Drupal\Core\File\FileSystemInterface::saveData(). 574 Call to deprecated function file_prepare_directory(): in Drupal 8.7.0, will be removed before Drupal 9.0.0. Use \Drupal\Core\File\FileSystemInterface::prepareDirectory(). ------ -----------------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------
Line tests/src/Traits/BlazyCreationTestTrait.php (in context of class Drupal\Tests\blazy\Kernel\BlazyKernelTestBase)
------ -----------------------------------------------------------------------------------------------------------------
497 Call to deprecated function file_unmanaged_copy(): in Drupal 8.7.0, will be removed before Drupal 9.0.0. Use \Drupal\Core\File\FileSystemInterface::copy(). 546 Call to deprecated function file_unmanaged_save_data(): in Drupal 8.7.0, will be removed before Drupal 9.0.0. Use \Drupal\Core\File\FileSystemInterface::saveData(). 574 Call to deprecated function file_prepare_directory(): in Drupal 8.7.0, will be removed before Drupal 9.0.0. Use \Drupal\Core\File\FileSystemInterface::prepareDirectory(). ------ -----------------------------------------------------------------------------------------------------------------
------ ----------------------------------------------------------------------------------------------------------------------
Line tests/src/Traits/BlazyCreationTestTrait.php (in context of class Drupal\Tests\blazy\Kernel\Views\BlazyViewsTestBase)
------ ----------------------------------------------------------------------------------------------------------------------
497 Call to deprecated function file_unmanaged_copy(): in Drupal 8.7.0, will be removed before Drupal 9.0.0. Use \Drupal\Core\File\FileSystemInterface::copy(). 546 Call to deprecated function file_unmanaged_save_data(): in Drupal 8.7.0, will be removed before Drupal 9.0.0. Use \Drupal\Core\File\FileSystemInterface::saveData(). 574 Call to deprecated function file_prepare_directory(): in Drupal 8.7.0, will be removed before Drupal 9.0.0. Use \Drupal\Core\File\FileSystemInterface::prepareDirectory(). ------ ----------------------------------------------------------------------------------------------------------------------
[ERROR] Found 15 errors
Fix all remaining errors to claim compatibility with Drupal 9.
Provide patches in related issues. Update this meta issue accordingly.
None.
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | blazy-3088298-9.patch | 3.87 KB | effulgentsia |
| #7 | blazy-3088298-7.patch | 5.11 KB | effulgentsia |
| #5 | 3088298.patch | 2.65 KB | chr.fritsch |
Comments
Comment #2
gausarts commentedThank you!
Let's be on the same page before applying most core-related fixes as otherwise your fixes will break 8.6 installs.
The current minimum Drupal version Blazy depends on is 8.6. We have 2 options:
upping it 8.7 or stick it to 8.6 for a while.
Please decide this beforehand. I myself prefer keeping it low unless 8.6 installs are 0, but it is not a must if you have compelling reasons.
Please share your thoughts for better decisions.
Without upping it, the only option to core-related issues is to postpone any fix.
Even leaving those core-related issues as they are now this module will still work fine at both D8.6 and D9. Meaning no issues with the current claim for D9 readiness, no issues with old D8.6. How is that? Because they are all optional. Nothing broken when those functions are finally removed.
Comment #3
gausarts commentedLet's postpone this till D8.6 EOL, if not 2022 or June 2020. Alternatively it can be re-opened anytime when Blazy depends on D8.8, likely Blazy 3.x.
Having said that, unless we have any disruptive change at D8.8+, Blazy should be compatible with D9 as discussed at comment no. 2.
Adding special tag to identify multiple duplicated issues.
Postponing so we know which issue to focus on to have stabilization and full release.
Comment #4
gausarts commentedComment #5
chr.fritschThis can be committed next week when 8.8 is out.
Comment #6
kristen polPer a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.
Comment #7
effulgentsia commentedUnpostponing this now that Drupal 8.8.0 is out and therefore 8.6 is unsupported.
#5 might be the better patch to commit if Blazy is willing to make a hard break from 8.6.
If Blazy wants to remain functional with 8.6 for a while longer (despite the fact that that's no longer a supported version of Drupal), here's a patch that achieves that in a way that stops Upgrade Status from complaining.
Comment #8
chr.fritschTBH I wouldn't add that complexity. If someone is still on 8.6, it's possible to use the current version of blazy... 🤷🏼♂️
As a module maintainer, you already have a lot of work. We shouldn't help people to use unsupported versions of Drupal.
Comment #9
effulgentsia commentedAgreed. Here's a simplified patch more along the lines of #5. Additionally, those changes are just to a test class. So it's not even breaking runtime functionality on 8.6, just stopping the ability to run the module's tests on 8.6, which I think is totally fine.
Comment #11
gausarts commentedThank you! Makes sense, I just realized some indeed affected test files only.
Setting back to Postpone for the rest of issues as seen in the related issues which should not hold off the full release.
Feel free to re-open should anyone have the remaining solutions. Thanks again for contribution!
Comment #12
gausarts commentedMoving forward faster as per #3079167: Implement TrustedCallbackInterface to fix deprecation notices by mistakes.
Comment #13
gausarts commentedI guess we can close this now. Feel free to re-open if I missed the obvious or anything, or any further deprecation along the way to D9.
We can re-use this one as a parent issue as needed to easily track related deprecation issues.
If anyone is hurt by this (side) change, I am truly sorry. I didn't mean to, but I just made mistakes, and tried to see it in the bright side.
Thank you for contribution!