Problem/Motivation

Some tests are very major version dependent - we should work out if that is necessary and if so can we code around it in some way.

See Drupal\Tests\system\Functional\Update\UpdatePathTestBaseFilledTest::testUpdateHookN for example

Proposed resolution

Some .info.yml files have
core_version_requirement: ^9 we could replace some of this with core_version_requirement: '*'

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

alexpott created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Normal » Major
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

We also have a number of tests that are using 8.x which didn't fail with the move to 9.0.x. For example: \Drupal\Tests\Core\Extension\ExtensionListTest. That test is using mocking and a virtual file system. On one hand there is no need to replace core: 8.x with anything - on the other it does make things quite confusing.

There's also stuff like core/modules/update/tests/update_test_new_module/8.x-1.0/update_test_new_module.tar.gz where the version is baked into the path.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Issue tags: +beta target

This seems like something we'd still want to do before 9.0.0.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Version: 9.0.x-dev » 9.2.x-dev
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: -beta target

Cleaning up leftover beta targets from 9.0.x.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Active » Closed (outdated)
Related issues: +#3359322: Fix various tests that fail every time we open a new major branch

I think this is fixed by #3359322: Fix various tests that fail every time we open a new major branch

These are the instances of core_version_requirement with a digit version. And none of these seems to be major version dependent.

$ git grep 'core_version_requirement: ^[0-9]'
core/modules/ckeditor5/tests/src/Kernel/CKEditor5PluginManagerTest.php:core_version_requirement: ^9
core/modules/package_manager/tests/fixtures/build_test_projects/alpha/1.0.0/alpha.info.yml.hide:core_version_requirement: ^9.7 || ^10
core/modules/package_manager/tests/fixtures/build_test_projects/alpha/1.1.0/alpha.info.yml.hide:core_version_requirement: ^9.7 || ^10
core/modules/package_manager/tests/fixtures/build_test_projects/main_module/main_module.info.yml.hide:core_version_requirement: ^9 || ^10
core/modules/package_manager/tests/fixtures/build_test_projects/main_module/main_module_submodule/main_module_submodule.info.yml.hide:core_version_requirement: ^9 || ^10
core/modules/system/tests/modules/system_core_incompatible_semver_test/system_core_incompatible_semver_test.info.yml:core_version_requirement: ^7
core/modules/system/tests/themes/test_invalid_core_semver/test_invalid_core_semver.info.yml:core_version_requirement: ^7

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.