Closed (fixed)
Project:
Drupal core
Version:
main
Component:
base system
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 May 2023 at 08:56 UTC
Updated:
9 Jun 2026 at 09:35 UTC
Jump to comment: Most recent
Problem/Motivation
See #3359077: Resolve test failures on 11.x branch, the same happened when we opened the 10.0.x branch.
Steps to reproduce
Create a new major branch, HEAD will break.
Proposed resolution
Refactor the tests so that they always pass regardless of the major branch name.
$ git grep -l 'Skipped due to major version-specific'
core/modules/announcements_feed/tests/src/FunctionalJavascript/AlertsJsonFeedTest.php
core/modules/announcements_feed/tests/src/Kernel/AnnounceFetcherTest.php
core/modules/announcements_feed/tests/src/Kernel/AnnounceFetcherUserTest.php
core/modules/locale/tests/src/Functional/LocaleNonInteractiveInstallTest.php
core/modules/system/tests/src/Functional/Module/DependencyTest.php
core/modules/system/tests/src/Functional/System/ThemeTest.php
core/modules/system/tests/src/Functional/UpdateSystem/UpdateScriptTest.php
Remaining tasks
core/modules/locale/tests/src/Functional/LocaleNonInteractiveInstallTest.php
Review
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3359322
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3359322-fix-the-various
changes, plain diff MR !15484
Comments
Comment #3
quietone commentedComment #5
quietone commentedHave a fix for all but one test, core/modules/locale/tests/src/Functional/LocaleNonInteractiveInstallTest.php. Anyone have ideas on how to fix that one? And
The change for AnnounceTestController seems odd to me. It may be better to create all the feeds in the test public file directory for consistency.
Comment #6
quietone commentedI meant to set this for review to review the current changes and to get ideas on how to fix LocaleNonInteractiveInstallTest.php
Comment #7
smustgrave commentedWould changing
to
Used claude to help look at this test and that phrase "Enter the password that accompanies your username." was from 2018 was that something core use to say?
Comment #8
quietone commentedThanks, yes that makes sense. I updated the test for the idea in #7 and ran it on 11.3.10, 11.x and main. It passed locally for all those. That suggests the problem was that the string "Enter the password that accompanies your username." was removed from core. And yes it was, on 2023-07-23 in #3376314: Remove the username and password descriptions from the login form. But the skip was added before that on 2023-05-10, #3359077: Resolve test failures on 11.x branch. Perhaps there was another problem as well that has since been fixed? I don't know.
Comment #9
smustgrave commentedGlad that worked out. Rest of the changes look fine to me. Neat to see less skipped tests :)
Comment #11
catchThis looks pretty good to me. Some of the version rewriting is a bit tricky but better than having to update fixtures every major etc.
Committed/pushed to main, thanks!