Some tests are failing for D8.8 and above:

  • \Drupal\Tests\feeds\Functional\FeedTypeListBuilderTest
  • \Drupal\Tests\feeds\Functional\FeedListBuilderTest
  • \Drupal\Tests\feeds\Unit\Feeds\Fetcher\HttpFetcherTest
  • \Drupal\Tests\feeds\Unit\Feeds\Parser\SyndicationParserTest

Let's try to fix these.

CommentFileSizeAuthor
#3 interdiff-3087672-2-3.txt1.1 KBmegachriz
#3 feeds-fix-tests-d88-3087672-3.patch3.92 KBmegachriz
#2 feeds-fix-tests-d88-3087672-2.patch3.09 KBmegachriz

Comments

MegaChriz created an issue. See original summary.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new feeds-fix-tests-d88-3087672-2.patch3.09 KB

Some of the tests were fixed. However, the error in SyndicationParserTest seems to be caused by #3039611-55: Update core PHP dependencies for 8.8.x.

megachriz’s picture

megachriz
Primary language Dutch
commented
StatusFileSize
new feeds-fix-tests-d88-3087672-3.patch3.92 KB
new interdiff-3087672-2-3.txt1.1 KB

Okay, the Syndication parser test mimics the service 'feed.bridge.reader' themselves and the requirements for constructing and configuring \Drupal\Component\Bridge\ZfExtensionManagerSfContainer (whatever this thing does) appears to have changed.

New patch.

  • MegaChriz committed ed5285f on 8.x-3.x 
    Issue #3087672 by MegaChriz: Fixed tests for D8.8.
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Cool. Tests are passing again. Committed #3.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.