Problem/Motivation

This hook is documented in the wrong module.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 move-views-ui-3087465-2.patch2.27 KBzuhair_ak

Comments

tim.plunkett created an issue. See original summary.

zuhair_ak’s picture

zuhair_ak
He/Him
Primary language Malayalam
Location Dubai
commented
Status: Active » Needs review
StatusFileSize
new move-views-ui-3087465-2.patch2.27 KB

Moved the code and upped the patch, I have put it inside "addtogroup hooks" comment but I dont understand what it means.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch.

1) Reviewed the code and have confirmed that the hook is in the views_ui module and not the views module in core/modules/views_ui/src/ViewEditForm.php:

    // Let other modules add additional links here.
    \Drupal::moduleHandler()->alter('views_ui_display_top_links', $element['extra_actions']['#links'], $view, $display_id);

2) Patch applies cleanly to 8.9, 9.0, and 9.1.

[mac:kristen:drupal-8.9.x-dev]$ patch -p1 < move-views-ui-3087465-2.patch
patching file core/modules/views/views.api.php
patching file core/modules/views_ui/views_ui.api.php

[mac:kristen:drupal-9.0.x-dev]$ patch -p1 < move-views-ui-3087465-2.patch
patching file core/modules/views/views.api.php
patching file core/modules/views_ui/views_ui.api.php

[mac:kristen:drupal-9.1.x-dev]$ patch -p1 < move-views-ui-3087465-2.patch
patching file core/modules/views/views.api.php
patching file core/modules/views_ui/views_ui.api.php

3) Compared old and new text and they match.

4) Placement in core/modules/views_ui/views_ui.api.php seems fine to me.

5) Tests pass.

6) Marking RTBC.

  • xjm committed 8a8be6c on 9.1.x 
    Issue #3087465 by zuhair_ak, tim.plunkett, Kristen Pol: Move...

  • xjm committed d81f1f2 on 9.0.x 
    Issue #3087465 by zuhair_ak, tim.plunkett, Kristen Pol: Move...

  • xjm committed 4c0b63c on 8.9.x 
    Issue #3087465 by zuhair_ak, tim.plunkett, Kristen Pol: Move...

  • xjm committed 9822917 on 8.8.x 
    Issue #3087465 by zuhair_ak, tim.plunkett, Kristen Pol: Move...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.1.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

As a documentation bugfix, this change is eligible for backport to the production branch. Committed to 9.1.x and cherry-picked to 9.0.x, 8.9.x, and 8.8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.