Move hook_views_ui_display_top_links_alter() to views_ui.api.php [#3087465]

Comment	File	Size	Author
#2	move-views-ui-3087465-2.patch	2.27 KB	zuhair_ak
8.9.x: PHP 7.1 & MySQL 5.7 27,959 pass

Comment #1

11 October 2019 at 17:59

tim.plunkett created an issue. See original summary.

Log in or register to post comments

Comment #2

zuhair_ak

He/Him

Malayalam

Dubai

CreditAttribution: zuhair_ak commented 7 November 2019 at 13:27

Status:

Active

» Needs review

File	Size
move-views-ui-3087465-2.patch	2.27 KB
8.9.x: PHP 7.1 & MySQL 5.7 27,959 pass

Moved the code and upped the patch, I have put it inside "addtogroup hooks" comment but I dont understand what it means.

Log in or register to post comments

Comment #3

7 November 2019 at 13:27

Version:

8.9.x-dev

» 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Log in or register to post comments

Comment #4

Kristen Pol

she/her

English

Santa Cruz, CA, USA

CreditAttribution: Kristen Pol at Hook 42 commented 9 May 2020 at 06:00

Status:

Needs review

» Reviewed & tested by the community

Thanks for the patch.

1) Reviewed the code and have confirmed that the hook is in the views_ui module and not the views module in core/modules/views_ui/src/ViewEditForm.php:

    // Let other modules add additional links here.
    \Drupal::moduleHandler()->alter('views_ui_display_top_links', $element['extra_actions']['#links'], $view, $display_id);

2) Patch applies cleanly to 8.9, 9.0, and 9.1.

[mac:kristen:drupal-8.9.x-dev]$ patch -p1 < move-views-ui-3087465-2.patch
patching file core/modules/views/views.api.php
patching file core/modules/views_ui/views_ui.api.php

[mac:kristen:drupal-9.0.x-dev]$ patch -p1 < move-views-ui-3087465-2.patch
patching file core/modules/views/views.api.php
patching file core/modules/views_ui/views_ui.api.php

[mac:kristen:drupal-9.1.x-dev]$ patch -p1 < move-views-ui-3087465-2.patch
patching file core/modules/views/views.api.php
patching file core/modules/views_ui/views_ui.api.php

3) Compared old and new text and they match.

4) Placement in core/modules/views_ui/views_ui.api.php seems fine to me.

5) Tests pass.

6) Marking RTBC.

Log in or register to post comments

Comment #5

9 May 2020 at 18:18

xjm committed 8a8be6c on 9.1.x

Issue #3087465 by zuhair_ak, tim.plunkett, Kristen Pol: Move...

Log in or register to post comments

Comment #6

9 May 2020 at 18:19

xjm committed d81f1f2 on 9.0.x

Issue #3087465 by zuhair_ak, tim.plunkett, Kristen Pol: Move...

Log in or register to post comments

Comment #7

9 May 2020 at 18:20

xjm committed 4c0b63c on 8.9.x

Issue #3087465 by zuhair_ak, tim.plunkett, Kristen Pol: Move...

Log in or register to post comments

Comment #8

9 May 2020 at 18:21

xjm committed 9822917 on 8.8.x

Issue #3087465 by zuhair_ak, tim.plunkett, Kristen Pol: Move...

Log in or register to post comments

Comment #9

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 9 May 2020 at 18:22

Version:	9.1.x-dev	» 8.8.x-dev
Status:	Reviewed & tested by the community	» Fixed

As a documentation bugfix, this change is eligible for backport to the production branch. Committed to 9.1.x and cherry-picked to 9.0.x, 8.9.x, and 8.8.x. Thanks!