Problem/Motivation

Now(Drupal 8.7.7) supports semantic versioning as implemented by the Composer project.

Proposed resolution

Add new key core_version_requirement in info.yml

Change records: https://www.drupal.org/node/3070687

CommentFileSizeAuthor
#8 Screenshot from 2019-10-10 18-31-04.png777.73 KBthalles
#2 blazy-Add_new_key_core_version_requirement_in_info.yml-3087084-2-D8.patch348 bytesthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Parent issue: #3087078: Add new key core_version_requirement in info.yml »
StatusFileSize
new blazy-Add_new_key_core_version_requirement_in_info.yml-3087084-2-D8.patch348 bytes

Follow a new patch.

Status: Needs review » Needs work

The last submitted patch, 2: blazy-Add_new_key_core_version_requirement_in_info.yml-3087084-2-D8.patch, failed testing. View results

gausarts’s picture

gausarts commented
Status: Needs work » Postponed (maintainer needs more info)

Thank you!

Does this break Drupal 8.6?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

as I understand it will not break, only the feature will not be recognized

gausarts’s picture

gausarts commented

I might be wrong, but a few weeks ago I tested this new line and broke Drupal 8.6. That was why I asked. The only reason was the minimum Blazy requires is 8.6. If you could confirm it, that'll be great. Thanks!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Postponed (maintainer needs more info) » Needs review

I created a clean install, did the modification and installed the module, it worked normally

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new Screenshot from 2019-10-10 18-31-04.png777.73 KB

gausarts’s picture

gausarts commented

You are right. I was wrong. I just remembered it failed only with minor version when I added 8.6 last time. Yours should work fine.

Thanks!

  • gausarts committed 291910b on 8.x-2.x authored by thalles 
    Issue #3087084 by thalles: Add new key core_version_requirement in info....
gausarts’s picture

gausarts commented
Status: Needs review » Fixed

Sorry for delay.

Committed. Thank you for contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.