Hi everyone!
In D7 version of the module - user is able to add places to its own weather display. And see those places in separate block.
Recently I had some time and was able to implement this functionality for D8 version.
It hasn't been tested well and there is still couple of todos left.
So anyone is welcome to continue!)
See my recent commit

CommentFileSizeAuthor
#6 user-customized-weather-display-port-3086847-1.patch1.56 KBakyrylenko

Comments

tarasich created an issue. See original summary.

tarasich’s picture

tarasich
Primary language Ukrainian
Location Kyiv
commented
Status: Active » Needs review

Hey there!
Just pushed an update, tested from my side. User managed weather display functionality works on D8 version now.
See my latest commit here.
Would be good if someone can test how it works in DEV version of the module.

galileo25’s picture

galileo25 commented

Everything works fine, but on the user profile page when adding a new location, the table is not updated untill cache cleared when the weather block is missing.

galileo25’s picture

galileo25 commented

Part-time I got an issue with $displayNumber variable in my watchdog

Notice: Undefined variable: displayNumber in Drupal\weather\Form\WeatherDisplayForm->buildForm() (line 210 of /var/www/html/web/modules/contrib/weather/src/Form/WeatherDisplayForm.php)

It references to the lines

    $form['number'] = [
      '#type' => 'value',
      '#value' => $displayNumber,
    ];

Where $displayNumber came undefined

galileo25’s picture

galileo25 commented
Status: Needs review » Needs work
akyrylenko’s picture

akyrylenko commented
StatusFileSize
new user-customized-weather-display-port-3086847-1.patch1.56 KB

Hi there,

I provide a patch for weather display where fixed log message:

Notice: Undefined variable: displayNumber in Drupal\weather\Form\WeatherDisplayForm->buildForm(), line 213

and successful update table after adding new location.
Please review

akyrylenko’s picture

akyrylenko commented
Status: Needs work » Needs review
ysamoylenko’s picture

ysamoylenko commented
Status: Needs review » Reviewed & tested by the community

The patch looks good for me and it solves the issue well. Happy to RTBC!

tarasich’s picture

tarasich
Primary language Ukrainian
Location Kyiv
commented

Looks awesome! Thank you guys!)
@ysamoylenko lets commit

ysamoylenko’s picture

ysamoylenko commented
Status: Reviewed & tested by the community » Fixed

The changes have been committed. Thanks, everyone for your participation in module development.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.