Tests at core 8.8 now produce the following @trigger_error message, due to commit in 8.8 on 9th October.

7x: Any entity_reference_autocomplete component of an entity_form_display must have a match_limit setting. The uid field on the node.scheduler_api_test.default form display is missing it. This BC layer will be removed before 9.0.0. See https://www.drupal.org/node/2863188
    1x in SchedulerApiTest::testAllowedPublishing from Drupal\Tests\scheduler\Functional
    1x in SchedulerApiTest::testAllowedUnpublishing from Drupal\Tests\scheduler\Functional
    1x in SchedulerApiTest::testApiNodeAction from Drupal\Tests\scheduler\Functional
    1x in SchedulerApiTest::testNidList from Drupal\Tests\scheduler\Functional
    1x in SchedulerApiTest::testNidListAlter from Drupal\Tests\scheduler\Functional
    1x in SchedulerApiTest::testHideField from Drupal\Tests\scheduler\Functional
    1x in SchedulerApiTest::testHookPublishUnpublishAction from Drupal\Tests\scheduler\Functional

https://www.drupal.org/node/2863188

CommentFileSizeAuthor
#4 3086762-4.change_uid_to_number.patch834 bytesjonathan1055
#3 3086762-3.add_match_limit.patch673 bytesjonathan1055

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented

#2863188: Hardcoded result size limit in the entity reference autocomplete widget.
The change record is https://www.drupal.org/node/3024684
The commit was on 9th October

jonathan1055’s picture

jonathan1055 commented
StatusFileSize
new 3086762-3.add_match_limit.patch673 bytes

Simple fix works ok on local testing.

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review
StatusFileSize
new 3086762-4.change_uid_to_number.patch834 bytes

The new schema with match_limit is only implemented in core 8.8 and above. This would mean we cannot have passing tests at 8.6 and 8.7. We do not actually need the uid field to be entity_reference_autocomplete, it can be a plain number. It was probably set to entity_reference_autocomplete by using an export function to get the .yml file after creating the content type interactively.

  • jonathan1055 committed a1aa5a2 on 8.x-1.x 
    Issue #3086762 by jonathan1055: Add match_limit to uid field of node....
jonathan1055’s picture

jonathan1055 commented
Title: Add match_limit to uid field of node.scheduler_api_test.default » Change scheduler_api_test uid from entity_reference_autocomplete to number to avoid match_limit deprecation
Status: Needs review » Fixed

Done.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.