Problem/Motivation

The primary tabs are not visually aligned on the left with other elements when the first tab is not active. This only affects the default state because the default state doesn't have any border or background.

Proposed resolution

Let's consider updating the design so that the default state looks visually aligned on the left with other elements.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 Captura de Pantalla 2019-10-09 a les 12.37.53.png36.36 KBckrina
#3 Screenshot 2019-10-07 22.39.37.png114.69 KBfhaeberle
#2 Screen Shot 2019-10-09 at 14.53.40.png11.04 KBlauriii
Screen Shot 2019-10-09 at 14.53.27.png67 byteslauriii
Screen Shot 2019-10-09 at 14.53.27.png11.47 KBlauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2019-10-09 at 14.53.40.png11.04 KB
fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
commented
Issue summary: View changes
StatusFileSize
new Screenshot 2019-10-07 22.39.37.png114.69 KB

Updating issue summary with intended alignment by parts of the design.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Component: User interface » Needs design
Issue summary: View changes
StatusFileSize
new Captura de Pantalla 2019-10-09 a les 12.37.53.png36.36 KB

Thanks @fhaeberle, but it's not the intended design, it's just one of the initial explorations that remains on some specs examples. Aligning it to the left has other problems, as you can see here: ;)

This needs some research&design work and it's not yet defined, so changing this to needs design for now so someone can invest the time on this.

fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
commented

@ckrina +1. That's why I raised concern against it in the previous issues. I'm also against doing this change on this stage where it isn't defined how hover and focus or the overall alignment is handled. Once we have reasonable designs for it, that could be considered again.
Edit: My only intention to update the issue summary with the left aligned menu was to show how it looks like in part of the exploration/design.

saschaeggi’s picture

saschaeggi
he/him
commented

I see this more as a "works as designed" for now, because it was intended to look like how it’s implemented. I agree with @fhaeberle not to change it at this point. Even if I agree it would be nicer to have the text aligned on the left, this leads to new issues.

saschaeggi’s picture

saschaeggi
he/him
commented

Update: sorry didn't saw the "8.x-2.x-dev" ;-)
“Easy” fix would be to indent the content below so it's aligned again.

saschaeggi’s picture

saschaeggi
he/him
commented
Parent issue: » #3086780: Improve horizontal alignment so that elements are aligned on a vertical line
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented

Thanks for taking care of it @fhaeberle! I was just concerned that it wasn't clear enough that this still needs design and tried to prevent getting anyone investing time implementing it :)

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Project: Claro » Drupal core
Version: 8.x-2.x-dev » 8.9.x-dev
Component: Needs design » Claro theme

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Active » Postponed (maintainer needs more info)

So question is this still a valid task?

smustgrave’s picture

smustgrave commented
Issue tags: +ClaroContributionDay2023
quietone’s picture

quietone commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

If I read this correctly #6 is saying this is working as designed. And there hasn't been confirmation that this is a problem from anyone else, therefore closing.