After debugging, I found the following issue: when we use an entity_reference field (with an entity browser for selection), we are not able to save default values properly:

$field_value, in our case looks like [ 'target_id' => 'media:123' ] where "123" is the mid of the media item. This is not valid and throws inside "PrimitiveTypeConstraintValidator", since this is supposed to be an integer, but 'media:123' is a string, but '123' would be valid. 

  if (isset($field_value['target_id']) && is_array($field_value['target_id'])) {
        $field_value = $field_value['target_id'];
      }

I think this should handle this case, but $field_value['target_id'] is not an array and would still contain 'media:123'

Is there a special use-case, we are missing to handle references?

CommentFileSizeAuthor
#6 Screenshot 2020-06-15 at 9.39.59 PM.png583.1 KBLal_
#6 Screenshot 2020-06-15 at 9.39.36 PM.png832.49 KBLal_
#4 interdiff.txt956 bytesb_sharpe
#4 3086275-media-handler.patch1.23 KBb_sharpe
#3 3086275-3.patch1.27 KBpratik_kamble

Comments

DrColossos created an issue. See original summary.

drcolossos’s picture

drcolossos commented

Just a quick heads-up:

If I add 

if (isset($field_value['target_id']) ) {
   [$type, $field_value] = explode(':',$field_value['target_id'] );
}

after your "odd term structure" fix, everything works as expected for the reference.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
StatusFileSize
new 3086275-3.patch1.27 KB

Patch to fix the issue related to the media reference entities.

b_sharpe’s picture

b_sharpe commented
Status: Active » Needs review
StatusFileSize
new 3086275-media-handler.patch1.23 KB
new interdiff.txt956 bytes

This was causing me undefined index errors when the handler was a single item (i.e. views, layout_library), also when media was used but the handler was not default:media the structure was different.

I've updated the patch to put in these checks, if someone wants to validate I will put this into next release.

ricardochefigueroa’s picture

ricardochefigueroa commented

#3 This patch worked for me. Thanks.

Lal_’s picture

Lal_
He\Him
commented
StatusFileSize
new Screenshot 2020-06-15 at 9.39.36 PM.png832.49 KB
new Screenshot 2020-06-15 at 9.39.59 PM.png583.1 KB

Moving the issues to RTBC as the patch solves the issues.... Adding the screen shots.

Lal_’s picture

Lal_
He\Him
commented
Status: Needs review » Reviewed & tested by the community

  • b_sharpe committed 10fdc6f on 8.x-1.x 
    Issue #3086275 by b_sharpe, pratik_kamble, Lal_: Usage with Entity...
b_sharpe’s picture

b_sharpe commented
Status: Reviewed & tested by the community » Fixed

Thanks all, committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

scotwith1t’s picture

scotwith1t
Location Birmingham, AL
commented

For me, this still only works with the autocomplete widget and does not set the default value on existing content when Media Library is set as the widget...I had to set to use autocomplete, resave to get the batch to run again, then switch back to Media Library for the correct/desired UX.

b_sharpe’s picture

b_sharpe commented

Widget submission format is definitely an issue, unfortunately I'm not sure how to remedy short of creating a case for each widget individually. For core that's likely ok and minimal, but contrib widgets will likely never be supported.