Views is up to version 3.23.

CommentFileSizeAuthor
#16 panopoly_core-update-views-3085860-16.patch836 bytesjeffm2001
#15 panopoly_core-update-views-3085860-15.patch809 bytesjeffm2001
#9 panopoly_core-update-views-3085860-9.patch1.28 KBcboyden
#8 panopoly_core-update_to_7.23_with_patches-3085860-8.patch1.16 KBaubjr_drupal
#6 panopoly_core-update_to_views-7.x-3.23_with_views_patches_for_3065777_and_2284423-3085860-6.patch964 bytesbyronveale
#5 panopoly_core-update_to_views-7.x-3.23_with_date_fallback_sort_fix-3085860-5.patch860 bytesbyronveale
#3 panopoly_core-update_to_views-7.x-3.23-3085860-3.patch739 bytesbyronveale

Comments

byronveale created an issue. See original summary.

byronveale’s picture

byronveale commented
Version: 7.x-1.66 » 7.x-1.x-dev

Whoops, cloned from older issue, so wrong version selected.

byronveale’s picture

byronveale commented
StatusFileSize
new panopoly_core-update_to_views-7.x-3.23-3085860-3.patch739 bytes

Here's a patch, will be testing shortly…

byronveale’s picture

byronveale commented
Status: Active » Needs review

Works for me, but…

byronveale’s picture

byronveale commented
StatusFileSize
new panopoly_core-update_to_views-7.x-3.23_with_date_fallback_sort_fix-3085860-5.patch860 bytes

Uploading a second version of this patch, to fix a bug we discovered when adding additional date sort criteria to serve as a fallback for exposed filters, that thankfully someone else experienced and wrote a patch to fix.

byronveale’s picture

byronveale commented
StatusFileSize
new panopoly_core-update_to_views-7.x-3.23_with_views_patches_for_3065777_and_2284423-3085860-6.patch964 bytes

Okay, lots of php Warnings and Notices came with 3.23. Uploading another patch with Views patches for both the previous sort fix and a quelling the errors fix.

aubjr_drupal’s picture

aubjr_drupal commented

I'd add in these patches as well (if possible):

I'm gonna add those other two patches you caught to our build script as well. I hope that the kinks in v3.23 continue to get worked out.

aubjr_drupal’s picture

aubjr_drupal commented
StatusFileSize
new panopoly_core-update_to_7.23_with_patches-3085860-8.patch1.16 KB

Here's the alternative patch with more fixes in it for #7 above.

cboyden’s picture

cboyden commented
StatusFileSize
new panopoly_core-update-views-3085860-9.patch1.28 KB

Here's an update to the patch in #8 that adds another Views patch for a PHP 7.2 compatibility issue.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Here's a test build on Travis:

https://travis-ci.org/panopoly/panopoly/builds/631089354

I still want to skim through the patches this is including and the Views changelog.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Reviewed & tested by the community

Skimmed the patches. They all seem good! About half of them are committed in upstream Views anyway. :-)

Once the tests pass, I'll merge this!

  • dsnopek committed 6662eed on 7.x-1.x authored by cboyden 
    Issue #3085860 by byronveale, aubjr_drupal, cboyden, dsnopek: Update...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Fixed

Committed!

jeffm2001’s picture

jeffm2001 commented
Status: Fixed » Needs work

FYI, the patch in #2977851: PHP 7.2: count() on non-Countable in views_many_to_one_helper was removed from the makefile (which makes sense because it was committed upstream) but if you read farther down in that issue, it was accidentally reverted so a patch is still needed.

jeffm2001’s picture

jeffm2001 commented
Status: Needs work » Needs review
StatusFileSize
new panopoly_core-update-views-3085860-15.patch809 bytes

Here's a patch that adds back in a re-rolled patch for that issue.

jeffm2001’s picture

jeffm2001 commented
StatusFileSize
new panopoly_core-update-views-3085860-16.patch836 bytes

Sorry, something order in that last patch was giving me trouble. This one is working.

  • dsnopek committed 71160a3 on 7.x-1.x authored by JeffM2001 
    Issue #3085860 by byronveale, JeffM2001, aubjr_drupal, cboyden, dsnopek...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Eep! Thanks for catching that :-) I've committed the last fix

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.