Whilst checking for PHP 7.2 compatibility this warning come up:

FILE: \modules\contrib\marketo_ma\marketo_ma.install
-----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
 98 | ERROR | "$this" can no longer be used in a plain function or method since PHP 7.1.
-----------------------------------------------------------------------------------------
CommentFileSizeAuthor
#2 php7_compatibility-3085587-2.patch624 bytesspokje

Issue fork marketo_ma-3085587

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new php7_compatibility-3085587-2.patch624 bytes
caspervoogt’s picture

caspervoogt commented
Related issues: +#3082418: "Retrieve from Marketo" button is disabled; cannot retrieve fields from Marketo.

That patch applies and works for me. It also solves https://www.drupal.org/project/marketo_ma/issues/3082418 for me.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Active » Reviewed & tested by the community

LGTM.

Tests could not pass but #3229666: Fix test suite should fix that.

  • neclimdul committed e9d758d on 8.x-2.x authored by Spokje 
    Issue #3085587 by Spokje: "$this" can no longer be used in a plain...
neclimdul’s picture

neclimdul
He/Him
commented
Status: Reviewed & tested by the community » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.