Comments

oknate created an issue. See original summary.

wim leers’s picture

Component: media system » Bartik theme
Issue tags: +Media Initiative, +CSS

This is caused by

@media all and (min-width: 560px) {
  .node .field--type-image {
    float: left; /* LTR */
    margin: 0 1em 0 0; /* LTR */
  }
  [dir="rtl"] .node .field--type-image {
    float: right;
    margin: 0 0 0 1em;
  }
  .node .field--type-image + .field--type-image {
    clear: both;
  }
}

in core/themes/bartik/css/components/field.css.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

komalk’s picture

Assigned: Unassigned » komalk
komalk’s picture

Assigned: komalk » Unassigned
Status: Active » Needs review
StatusFileSize
new682 bytes
priyanka.sahni’s picture

Assigned: Unassigned » priyanka.sahni
priyanka.sahni’s picture

Status: Needs review » Needs work
StatusFileSize
new288.64 KB
new302.5 KB
new304.7 KB

I have tested and verified by applying the patch #6 and it was not fixed.

Steps to test-
1. Go to the admin site.
2. Go to admin/appearance
3. In the Administration theme , select Bartik.
4. Go to admin/modules , enable Media, Media Library.
5. Go to admin/config/content/formats
6. In the text editor , from the Available buttons add the media type in Active toolbar.
7. In the Enabled filters , enable these filters Align images and Embed media and click on save configuration.

Before Patch view -
BeforePatch

After Patch edit -
AfterPatchEdit

After Patch view -
AfterPatchView

priyanka.sahni’s picture

Assigned: priyanka.sahni » Unassigned
indrajithkb’s picture

Assigned: Unassigned » indrajithkb
indrajithkb’s picture

Assigned: indrajithkb » Unassigned
Status: Needs work » Needs review
StatusFileSize
new167.62 KB
new846 bytes
new916 bytes

Hi @komalkolekar from your patch #6 it's showing u just removed the codes which @Wim Leers mentioned in #2.
as per the comment #8 issue is still there.
i have created the patch please check.

attaching screen-shot:
issue after patch applied

priyanka.sahni’s picture

Assigned: Unassigned » priyanka.sahni
priyanka.sahni’s picture

Assigned: priyanka.sahni » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new212.66 KB
new213.28 KB

I have tested and re-verified by applying the patch #11 and it was fixed now.

AfterPatch_11_Edit
AfterPatch_11_Edit

AfterPatch_11_View
AfterPatch_11_View

xjm’s picture

Removed credit for #6 -- please make sure that when you create patches, you're fixing the problem that's described in the issue. Glad that the manual testing caught this. :)

larowlan’s picture

Status: Reviewed & tested by the community » Needs review

Is this duplicated by #3126783: Image align center not working - can someone please confirm and I'll close it and credit the contributors from there here.

priyanka.sahni’s picture

@larowlan Yes these two are duplicate.

lauriii’s picture

Status: Needs review » Closed (duplicate)
Issue tags: -Needs frontend framework manager review

This seems like a duplicate of #3085436: Center alignment of media embeds doesn't work in Bartik. I credited people from issue there.