In #3079738-49: Add Claro administration theme to core, I surfaced a few needs for image optimizations, in points 22, 23 and 28.

(Important: point 16 cannot be fixed without un-inlining those SVGs! See #3085245: Un-inline SVGs in pcss.css files, add build tool to inline them when compiled for that.)

CommentFileSizeAuthor
#8 Screenshot 2019-10-03 at 20.05.29.png113.36 KBwim leers
#4 3085243-4.patch238.05 KBwim leers
#2 3085243-2.patch49.88 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3085243-2.patch49.88 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
Related issues: +#3085245: Un-inline SVGs in pcss.css files, add build tool to inline them when compiled
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new 3085243-4.patch238.05 KB

I forgot --binary 🤦‍♂️

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

Thank you! Could you by any chance add steps for optimizing the images to the Claro development documentation?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Done: https://www.drupal.org/docs/8/modules/claro/development#s-working-on-images

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Needs work

Awesome, thank you!

I think there's still a few more images that could be optimized:

  • images/src/message--status.svg
  • images/core/cccccc/clock.svg
  • images/core/cccccc/server.svg
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new Screenshot 2019-10-03 at 20.05.29.png113.36 KB

ImageOptim says no:

  • lauriii committed 13ecee9 on 8.x-2.x 
    Issue #3085243 by Wim Leers: Optimize images per core patch review at #...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Fixed

Interesting. 🧐Thank you @Wim Leers!

  • lauriii committed 699f72a on 8.x-1.x 
    Issue #3085243 by Wim Leers: Optimize images per core patch review at #...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.