Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Replace deprecated create_function().
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | remove_deprecated_function-3084889.patch | 4.02 KB | Rangaswini |
| #2 | evaluate-3084889.patch | 2.5 KB | Rangaswini |
Comments
Comment #2
Rangaswini CreditAttribution: Rangaswini at QED42 commentedComment #3
Rangaswini CreditAttribution: Rangaswini at QED42 commentedComment #4
Rangaswini CreditAttribution: Rangaswini at QED42 commentedI have removed deprecated function eval(). Added external library eval-math-master to evaluate the mathematical expression.
Comment #5
Rangaswini CreditAttribution: Rangaswini at QED42 commentedComment #6
truptidiwani CreditAttribution: truptidiwani at QED42 commentedComment #7
truptidiwani CreditAttribution: truptidiwani at QED42 commentedI have reviewed the patch-
https://www.drupal.org/files/issues/2019-10-04/remove_deprecated_functio... and thus its working well.
Checked:
- The patch is being applied successfully and have tested the following test cases.- For addition, subtraction,divide,multiply,backsapce,clear.
- The libarary eval-math is applied and is working well.
Comment #8
truptidiwani CreditAttribution: truptidiwani at QED42 commentedComment #10
JayKandariThank you @Rangaswini & @truptidiwani for your contributions.
Patch looks okay to me.
There are few coding standards issue in this, but this can be covered in #3086737 ticket.
Comment #11
JayKandariComment #12
JayKandari