TODOs:
* There are lots of commented code which should not be a part of the code.
* Run phpcs to cleanup the code and implement the recommendations.
* Correct the inline comments.

CommentFileSizeAuthor
#8 3086737-8.patch9.05 KBLal_
#7 3086737-7.patch7.22 KBLal_
#2 3086737.patch8.83 KBLal_

Comments

JayKandari created an issue. See original summary.

Lal_’s picture

Status: Active » Needs review
StatusFileSize
new8.83 KB
truptidiwani’s picture

Assigned: Unassigned » truptidiwani
truptidiwani’s picture

Patch looks good!

truptidiwani’s picture

Assigned: truptidiwani » Unassigned
jaykandari’s picture

Status: Needs review » Needs work

Thank you @lal_ for the patch, I have listed the following minor issues, which ideally phpcs should have returned, not sure why this didn't come. Anyways, if these can be fixed would be great.

  1. +++ b/.idea/formula_field.iml
    @@ -0,0 +1,8 @@
    \ No newline at end of file
    

    Require a newline at end of file.

  2. +++ b/.idea/misc.xml
    @@ -0,0 +1,6 @@
    \ No newline at end of file
    

    Require a new line at EOF.

  3. +++ b/.idea/modules.xml
    @@ -0,0 +1,8 @@
    \ No newline at end of file
    

    Require a new line at EOF.

  4. +++ b/.idea/vcs.xml
    @@ -0,0 +1,6 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<project version="4">
    +  <component name="VcsDirectoryMappings">
    +    <mapping directory="$PROJECT_DIR$" vcs="Git" />
    +  </component>
    +</project>
    

    Don't think this file is required.

Infact, all`.idea` folder files are unnecessary. Can you please review it once.
Thanks!!

Lal_’s picture

Status: Needs work » Needs review
StatusFileSize
new7.22 KB

Oops... Sorry for that :-P

Lal_’s picture

StatusFileSize
new9.05 KB

rebased with the new commit

  • JayKandari committed 01d4c95 on 7.x-2.x authored by Lal_
    Issue #3086737 by Lal_, truptidiwani: Clean coding style for...
jaykandari’s picture

Status: Needs review » Fixed

Thanks!
committed and pushed to 7.x-2.x branch. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.