Closed (fixed)
Project:
Formula Field
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
9 Oct 2019 at 09:49 UTC
Updated:
24 Oct 2019 at 14:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Lal_Comment #3
truptidiwani commentedComment #4
truptidiwani commentedPatch looks good!
Comment #5
truptidiwani commentedComment #6
jaykandariThank you @lal_ for the patch, I have listed the following minor issues, which ideally phpcs should have returned, not sure why this didn't come. Anyways, if these can be fixed would be great.
Require a newline at end of file.
Require a new line at EOF.
Require a new line at EOF.
Don't think this file is required.
Infact, all`.idea` folder files are unnecessary. Can you please review it once.
Thanks!!
Comment #7
Lal_Oops... Sorry for that :-P
Comment #8
Lal_rebased with the new commit
Comment #10
jaykandariThanks!
committed and pushed to 7.x-2.x branch. :)