Part of #3083583: [META] Discourage non-inclusive use of the HTML title attribute

Problem/Motivation

The site-name link in the SystemBrandingBlock has a title attribute which is inaccessible to many groups of users, and is of little use.

Proposed resolution

Remove the title attribute from the site-name link in the system branding block template, for all core themes.

Remaining tasks

Patch.

CommentFileSizeAuthor
#19 Screenshot from 2020-08-20 09-48-58.png328.1 KBranjith_kumar_k_u
#14 title-remove.png240.78 KBsd9121
#11 interdiff_9-10.txt994 bytesramya balasubramanian
#11 remove-title-attribute-from-site-name-link-3084441-10.patch6.3 KBramya balasubramanian
#9 interdiff_3-9.txt884 bytesramya balasubramanian
#9 remove-title-attributes-from-site-name-link-system-branding-3084441-9.patch4.97 KBramya balasubramanian
#6 issue-3084441-3.patch4.66 KBthemusician
#2 3084441-2.patch3.33 KBandrewmacpherson

Comments

andrewmacpherson created an issue. See original summary.

andrewmacpherson’s picture

andrewmacpherson commented
Status: Active » Needs review
StatusFileSize
new 3084441-2.patch3.33 KB

Simple patch for the twig templates.

I haven't checked to see if this affects tests. Let's see what the bots say.

andrewmacpherson’s picture

andrewmacpherson commented
Issue tags: +Accessibility

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

themusician’s picture

themusician commented
StatusFileSize
new issue-3084441-3.patch4.66 KB

Reroll of andrewmacpherson's patch adding in the block for stable9 as well.

Status: Needs review » Needs work

The last submitted patch, 6: issue-3084441-3.patch, failed testing. View results

ramya balasubramanian’s picture

ramya balasubramanian commented

Working on it. Will try to fix this test case failure

ramya balasubramanian’s picture

ramya balasubramanian commented
Status: Needs work » Needs review
StatusFileSize
new remove-title-attributes-from-site-name-link-system-branding-3084441-9.patch4.97 KB
new interdiff_3-9.txt884 bytes

Hi,

Updated the patch. Please have a look.

Status: Needs review » Needs work

The last submitted patch, 9: remove-title-attributes-from-site-name-link-system-branding-3084441-9.patch, failed testing. View results

ramya balasubramanian’s picture

ramya balasubramanian commented
Status: Needs work » Needs review
StatusFileSize
new remove-title-attribute-from-site-name-link-3084441-10.patch6.3 KB
new interdiff_9-10.txt994 bytes

Updating the code in Claro and seven theme as per the previous test case Failure. I hope this will fix this test case failure.

The last submitted patch, 9: remove-title-attributes-from-site-name-link-system-branding-3084441-9.patch, failed testing. View results

sd9121’s picture

sd9121 commented
Assigned: Unassigned » sd9121
sd9121’s picture

sd9121 commented
Assigned: sd9121 » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new title-remove.png240.78 KB

@Ramya Balasubramanian,

I have reviewed your patch and it looks good to me.

Screenshot for the reference

remove title attr

Thanks!

hansa11’s picture

hansa11 commented

RTBC +1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

I think we should have a change record for the removal of title attributes. This change looks good but we should inform users. This is good for two reasons:

andrewmacpherson’s picture

andrewmacpherson commented
Assigned: Unassigned » andrewmacpherson
Status: Needs work » Needs review
Issue tags: -Needs change record

Change record here: Title attribute removed from site-name link in SystemBrandingBlock

I said it impacts themers and distro developers.

andrewmacpherson’s picture

andrewmacpherson commented
Assigned: andrewmacpherson » Unassigned
ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new Screenshot from 2020-08-20 09-48-58.png328.1 KB

I have reviewed the patch "remove-title-attribute-from-site-name-link-3084441-10.patch" in drupal 9.1 dev version, the patch applied successfully.It removes the title attribute from the site-name link in the system branding block template.

screenshot

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
Status: Needs review » Reviewed & tested by the community

  • lauriii committed 73f1151 on 9.1.x 
    Issue #3084441 by Ramya Balasubramanian, andrewmacpherson, theMusician,...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed 73f1151 and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.