Remove title attribute from site-name link in system branding block [#3084441]

Part of #3083583: [META] Discourage non-inclusive use of the HTML title attribute

Problem/Motivation

The site-name link in the SystemBrandingBlock has a title attribute which is inaccessible to many groups of users, and is of little use.

Proposed resolution

Remove the title attribute from the site-name link in the system branding block template, for all core themes.

Remaining tasks

Patch.

Comment	File	Size	Author
#19	Screenshot from 2020-08-20 09-48-58.png	328.1 KB	ranjith_kumar_k_u
#14	title-remove.png	240.78 KB	sd9121
#11	interdiff_9-10.txt	994 bytes	Ramya Balasubramanian
#11	remove-title-attribute-from-site-name-link-3084441-10.patch	6.3 KB	Ramya Balasubramanian
#11	9.1.x: PHP 7.4 & MySQL 5.7 27,517 pass
#9	interdiff_3-9.txt	884 bytes	Ramya Balasubramanian
#9	remove-title-attributes-from-site-name-link-system-branding-3084441-9.patch	4.97 KB	Ramya Balasubramanian
#9	9.1.x: PHP 7.4 & MySQL 5.7 27,412 pass, 1 fail
#6	issue-3084441-3.patch	4.66 KB	theMusician
#6	9.1.x: PHP 7.4 & MySQL 5.7 27,412 pass, 1 fail PHP 7.4 & MySQL 5.7 27,412 pass, 1 fail
#2	3084441-2.patch	3.33 KB	andrewmacpherson
#2	8.8.x: PHP 7.1 & MySQL 5.7 28,265 pass 8.9.x: PHP 7.1 & MySQL 5.7 28,434 pass, 1 fail 9.0.x: PHP 7.1 & MySQL 5.7 Composer error. Unable to continue. PHP 7.1 & MySQL 5.7 Composer error. Unable to continue. 9.1.x: PHP 7.3 & MySQL 5.7 27,412 pass, 1 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

28 September 2019 at 18:57

andrewmacpherson created an issue. See original summary.

Comment #2

andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commented 28 September 2019 at 19:04

Status:

Active

» Needs review

File	Size
3084441-2.patch	3.33 KB
8.8.x: PHP 7.1 & MySQL 5.7 28,265 pass 8.9.x: PHP 7.1 & MySQL 5.7 28,434 pass, 1 fail 9.0.x: PHP 7.1 & MySQL 5.7 Composer error. Unable to continue. PHP 7.1 & MySQL 5.7 Composer error. Unable to continue. 9.1.x: PHP 7.3 & MySQL 5.7 27,412 pass, 1 fail

File

Size

3084441-2.patch

3.33 KB

8.8.x:
PHP 7.1 & MySQL 5.7 28,265 pass

8.9.x:
PHP 7.1 & MySQL 5.7 28,434 pass, 1 fail

9.1.x:
PHP 7.3 & MySQL 5.7 27,412 pass, 1 fail

Simple patch for the twig templates.

I haven't checked to see if this affects tests. Let's see what the bots say.

Comment #3

andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commented 28 September 2019 at 20:47

Issue tags:

+Accessibility

Comment #4

28 September 2019 at 20:47

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #5

28 September 2019 at 20:47

Version:

8.9.x-dev

» 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #6

theMusician CreditAttribution: theMusician as a volunteer and at Western Washington University commented 21 July 2020 at 04:48

File	Size
issue-3084441-3.patch	4.66 KB
9.1.x: PHP 7.4 & MySQL 5.7 27,412 pass, 1 fail PHP 7.4 & MySQL 5.7 27,412 pass, 1 fail

Reroll of andrewmacpherson's patch adding in the block for stable9 as well.

Comment #7

21 July 2020 at 05:49

Status:

Needs review

» Needs work

The last submitted patch, 6: issue-3084441-3.patch, failed testing. View results

Comment #8

Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company for Drupal India Association commented 21 July 2020 at 07:52

Working on it. Will try to fix this test case failure

Comment #9

Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company for Drupal India Association commented 21 July 2020 at 09:32

Status:

Needs work

» Needs review

File	Size
remove-title-attributes-from-site-name-link-system-branding-3084441-9.patch	4.97 KB
9.1.x: PHP 7.4 & MySQL 5.7 27,412 pass, 1 fail
interdiff_3-9.txt	884 bytes

Hi,

Updated the patch. Please have a look.

Comment #10

21 July 2020 at 10:28

Status:

Needs review

» Needs work

The last submitted patch, 9: remove-title-attributes-from-site-name-link-system-branding-3084441-9.patch, failed testing. View results

Comment #11

Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian at Srijan | A Material+ Company for Drupal India Association commented 21 July 2020 at 12:11

Status:

Needs work

» Needs review

File	Size
remove-title-attribute-from-site-name-link-3084441-10.patch	6.3 KB
9.1.x: PHP 7.4 & MySQL 5.7 27,517 pass
interdiff_9-10.txt	994 bytes

Updating the code in Claro and seven theme as per the previous test case Failure. I hope this will fix this test case failure.

Comment #12

21 July 2020 at 12:23

The last submitted patch, 9: remove-title-attributes-from-site-name-link-system-branding-3084441-9.patch, failed testing. View results

Comment #13

sd9121 CreditAttribution: sd9121 as a volunteer and at QED42 commented 22 July 2020 at 12:47

Assigned:

Unassigned

» sd9121

Comment #14

sd9121 CreditAttribution: sd9121 as a volunteer and at QED42 commented 22 July 2020 at 12:57

Assigned:	sd9121	» Unassigned
Status:	Needs review	» Reviewed & tested by the community

File	Size
title-remove.png	240.78 KB

@Ramya Balasubramanian,

I have reviewed your patch and it looks good to me.

Screenshot for the reference

remove title attr

Thanks!

Comment #15

hansa11 CreditAttribution: hansa11 as a volunteer and at QED42 commented 23 July 2020 at 05:08

RTBC +1

Comment #16

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 31 July 2020 at 23:14

Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Needs change record

I think we should have a change record for the removal of title attributes. This change looks good but we should inform users. This is good for two reasons:

If they have customised the branding block template then they might update their customised version - for example http://codcontrib.hank.vps-private.net/node/29531798
In the unlikely event they have some code that relies on the title attribute.

Comment #17

andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commented 4 August 2020 at 00:48

Assigned:	Unassigned	» andrewmacpherson
Status:	Needs work	» Needs review
Issue tags:	-Needs change record

Change record here: Title attribute removed from site-name link in SystemBrandingBlock

I said it impacts themers and distro developers.

Comment #18

andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commented 4 August 2020 at 00:57

Assigned:

andrewmacpherson

» Unassigned

Comment #19

ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commented 20 August 2020 at 04:29

File	Size
Screenshot from 2020-08-20 09-48-58.png	328.1 KB

I have reviewed the patch "remove-title-attribute-from-site-name-link-3084441-10.patch" in drupal 9.1 dev version, the patch applied successfully.It removes the title attribute from the site-name link in the system branding block template.

screenshot

Comment #20

ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commented 20 August 2020 at 04:30

Status:

Needs review

» Reviewed & tested by the community

Comment #21

20 August 2020 at 15:36

lauriii committed 73f1151 on 9.1.x

Issue #3084441 by Ramya Balasubramanian, andrewmacpherson, theMusician,...

Comment #22

lauriii

he/him

Finnish

Finland

CreditAttribution: lauriii at Acquia commented 20 August 2020 at 15:36

Status:

Reviewed & tested by the community

» Fixed

Committed 73f1151 and pushed to 9.1.x. Thanks!

Comment #23

3 September 2020 at 15:39

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Remove title attribute from site-name link in system branding block

Problem/Motivation

Proposed resolution

Remaining tasks

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Change records for this issue

Parent issue

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community