Closed (fixed)
Project:
Send Notification to Slack
Version:
8.x-1.0
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Sep 2019 at 19:17 UTC
Updated:
24 Oct 2019 at 14:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sbrown1038 commentedComment #3
pratik_kambleComment #4
Lal_Comment #5
Lal_Well, as of now this will gonna do the trick but it would be much better if we have more structured data so that it will be less confusing
Comment #6
Lal_Comment #7
ambuj_gupta commentedComment #8
ambuj_gupta commentedIt is working as expected, but while Testing observed two issues:
Hi @Lal_, Please fix above mentioned issue.
Comment #9
Lal_@ambuj30oct good catch
Comment #10
Lal_quick fix
Comment #11
ambuj_gupta commentedTested and verified the module after adding the patch created by @Lal_. And it is working as expected.
Comment #12
ambuj_gupta commentedComment #13
pratik_kamble@Lal_ As per functionality-wise patch looks good but there are coding standard issues. Please fix them.
Comment #14
Lal_oops missed that
Comment #16
pratik_kamble