[meta] Convert some tests to Build tests

Let's see if one big patch is enough or if we need to bikeshed into multiple sub issues. The interdiff is against what I think is the last patch where all of these things were included in #3031379: Add a new test type to do real update testing.

The lint errors was a trailing comma issue when calling into a function. Hopefully this works more better this time on the test bot.

Caught another issue.

+++ b/core/tests/Drupal/BuildTests/QuickStart/QuickStartTestBase.php
@@ -0,0 +1,64 @@
+class QuickStartTestBase extends BuildTestBase {

This class should probably be abstract.

+++ b/core/tests/Drupal/BuildTests/Update/UpdateSiteDrushTest.php
@@ -0,0 +1,76 @@
+    $this->executeCommand('git config user.email "drupalci@no-reply.drupal.org"');
...
+    $this->executeCommand('git config user.name "Drupal CI"');

Instead of the above, the following is what seems to be used on test bots.

git config --global user.email "drupalci@drupalci.org" &&
git config --global user.name "The Testbot"

This fixes everything but one failure. Still investigating it.

Its confusing because I can't reproduce the failures on local. But let's try this.

14.1-3: done
14.3: I've added all 3 major versions of drush 8,9,10(master). Drush supports chaining so we should cover all the bases this way. And given the strong complaints last time w/ Phar and drush, testing w/ drush is a good idea.
14.4: not addressed
14.5: Drupal\BuildTests\TestSiteApplication\InstallTest will fail in fail patch because I removed the changes to TestSiteInstallCommand. The tests uncovers an existing bug w/ TestSiteInstallCommand that needs to be resolved. See #3031379-114: Add a new test type to do real update testing for more background.
14.6: not addressed

Will pick up the following w/ a later round of feedback.

1. +++ b/core/tests/Drupal/BuildTests/Update/UpdateSiteDrushTest.php
   @@ -4,6 +4,7 @@
   +use Symfony\Component\Finder\Finder;
   

   Unused import.

2. +++ b/core/tests/Drupal/BuildTests/Update/UpdateSiteDrushTest.php
   @@ -17,9 +18,16 @@
   +      ->notPath('/sites\/default\/settings\..*php/');
   

   This should be ->notName('drushrc.php');

#3087862: TestSiteInstallCommand doesn't work with build tests is now opened. And #3085728: Add access rules for build tests as well. The later has bits of the patch in this meta included in it. So, it does look like we're going the meta route here. Once some of those land, I'll open up a few more follow-ups to catch the rest of the things.

1. +++ b/core/tests/Drupal/BuildTests/Update/UpdateSiteDrushTest.php
   @@ -0,0 +1,98 @@
   +class UpdateSiteDrushTest extends BuildTestBase {
   

   This test has to be allowed to fail. And we're not used to dealing with tests that are allowed to fail.

2. +++ b/core/tests/Drupal/BuildTests/Update/UpdateTest.php
   @@ -0,0 +1,101 @@
   +  public function provideVersions() {
   +    return [
   +      ['8.6.x'],
   +      ['8.7.x'],
   +      ['8.8.x'],
   +    ];
   +  }
   

   This is cool

3. +++ b/core/tests/Drupal/Tests/Scripts/TestSiteApplicationTest.php
   @@ -49,6 +49,7 @@ protected function setUp() {
   +    $this->markTestIncomplete('Replace with build test.');
   
   @@ -67,6 +68,7 @@ public function testInstallWithNonExistingFile() {
   +    $this->markTestIncomplete('Replace with build test.');
   
   @@ -106,6 +108,7 @@ public function testInstallWithNonSetupClass() {
   +    $this->markTestIncomplete('Replace with build test.');
   
   @@ -206,6 +209,7 @@ public function testInstallScript() {
   +    $this->markTestIncomplete('Replace with build test.');
   
   @@ -243,6 +247,7 @@ public function testInstallInDifferentLanguage() {
   +    $this->markTestIncomplete('Replace with build test.');
   
   @@ -317,6 +322,7 @@ public function testUserLogin() {
   +    $this->markTestIncomplete('Replace with build test.');
   

   This shouldn't be done in this issue. We shouldn't end up with less test coverage.

Cleaning up leftover beta targets from 9.0.x.

this is just a reroll, done because #3087862: TestSiteInstallCommand doesn't work with build tests was committed. The new tests are failing locally, but first the reroll.

I have fixed cs error. please review it

@Anchal_gupta, thanks for the interest in the issue. What we both failed to do was to run the code quality checks before uploading the patch. Have a look at the instructions for running the coding standard checks locally so you can be sure the tests will run before uploading a patch.

I get different test results locally. For example, both of these pass locally.

This Drupal\BuildTests\Composer\Component\ComponentsIsolatedBuildTest::testComponentComposerJson with data set #0 ('/Version') fails on the testbot but passes locally.

 Drupal\BuildTests\QuickStart\InstallTest::testInstall with data set "standard" ('standard')
Symfony\Component\Filesystem\Exception\IOException: Failed to copy "/var/www/html/core/lib/Drupal/Core/StringTranslation/TranslationInterface.php" to "/tmp/build_workspace_ed518620268abc3a4dd2565fb31bf3abK6ZztE/core/lib/Drupal/Core/StringTranslation/TranslationInterface.php" because target file could not be opened for writing.

Not sure what the next step is.

Rerolling.

#16.1 and 2. Done
#18. Not done, added it to the remaining tasks
#21.3 Removed the changes and added the list of test to the remaining tasks.

UpdateSiteDrushTest is failing with:

Fatal error: Cannot redeclare theme_get_registry() (previously declared in /tmp/build_workspace_386b42cbab37b393ba776f4c01dadb4dSHCm06/core/includes/theme.inc:91) in /var/www/html/core/includes/theme.inc on line 91\n
' contains "Installation complete.".

How to address that?

Just a reroll. And type to run just the Build tests.

I should have known that would not work.

I noticed that other quickstart tests are checking the sqlite version, so I copied that code block to these tests. Also, updated version numbers.

Local testing isn't working for me because I use a personal git hook and that causes failures for chmod. I haven't looked closely but it may be because it is a symbolic link.

I don't know why this is failing with

1) Drupal\BuildTests\Update\UpdateSiteDrushTest::testSiteUpdateWithDrush with data set "12.x" ('drush/drush:12.x')
Failed asserting that ' You are about to:\n
 * Create a sites/default/settings.php file\n
 * CREATE the 'db.sqlite' database.\n
\n
 // Do you want to continue?: yes.                                              \n
\n
' contains "Installation complete.".

what it should be non-interactive, $this->executeCommand('drush site-install --db-url=sqlite://db.sqlite -y');.

Show the error output using an assert.

Well, that is a different error than what I get locally.

Moved past that error and on to a new one.

1) Drupal\BuildTests\Update\UpdateSiteDrushTest::testSiteUpdateWithDrush with data set "12.x" ('drush/drush:12.x')
COMMAND: drush updb -y
OUTPUT:
ERROR: PHP Fatal error:  Declaration of Drush\Command\DrushInputAdapter::getFirstArgument() must be compatible with Symfony\Component\Console\Input\InputInterface::getFirstArgument(): ?string in phar:///usr/local/bin/drush/lib/Drush/Command/DrushInputAdapter.php on line 54
Drush command terminated abnormally due to an unrecoverable error.   �[31;40m�[1m[error]�[0m
Error: Declaration of
Drush\Command\DrushInputAdapter::getFirstArgument() must be
compatible with
Symfony\Component\Console\Input\InputInterface::getFirstArgument():
?string in
phar:///usr/local/bin/drush/lib/Drush/Command/DrushInputAdapter.php,
line 54

Should it not be using vendor/bin/drush?

DrushInputAdapter was Removed from Drush in 2017.

I moved the Drush test to #3377980: Add BuildTest for testing update using Drush, with links to the core ideas issue about adding drush.
And the quickstart tests to #3377981: Add BuildTest for testing Quickstart install and update

I think Drupal\Tests\Scripts\TestSiteApplicationTest is covered by #2962157: TestSiteApplicationTest requires a database despite being a unit test

Changing to active because the patches have moved to other issues.

+++ b/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php
@@ -155,7 +155,6 @@ abstract class BuildTestBase extends TestCase {
-    $this->phpFinder = new PhpExecutableFinder();

This is the only change that is not yet in another issue. This currently an unused property.

And there is #2984031: Create Build Tests For Composer and Drupal