Closed (fixed)
Project:
Drupal core
Version:
8.8.x-dev
Component:
simpletest.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Oct 2019 at 04:36 UTC
Updated:
6 Nov 2019 at 09:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
heddnAutomatic updates module uses a version strings (with periods in them) for its testing. Here's the diff of what I do over top of BTB to get those tests to pass.
Comment #3
heddnLet's start the discussion.
Comment #4
mile23This looks fine. We should also document in the docblock that .ht.router.php will be used if it's present.
Comment #5
heddnComment #6
mile23Excellent. :-)
Comment #7
webchickGiven 8.5.x is already not supported, and definitely not by the time 8.8.x ships, do we need the conditional?
Also, this may be a silly question, but is there anyway to test this? That's a pretty glaring bug to not use a file we're depending on, no?
Comment #9
heddnWe can't always be sure how folks will use build tests. They might want to use it with 1) non-drupal install 2) very old drupal install 3) something else I can't think of where the router doesn't exist.
There is a way to test it and I can add a test.
Comment #10
heddnInterdiff is the tests only patch. Note, this pulls in quickstart base from #3082230: [meta] Convert some tests to Build tests. Which just means that meta will need a re-roll if it lands here first.
Comment #11
heddnI really muffed up that test only patch. Here are updated patches.
Comment #13
heddnYeah, tests passed.
Comment #14
mile23This counts as a test improvement for a new testing feature in 8.8.0, so we can target for 8.8.x.
Comment #15
heddnComment #16
mile23LGTM.
Comment #17
alexpottCommitted and pushed f6b2481aee to 9.0.x and 2a58c7ef79 to 8.9.x. Thanks!
Will backport this to 8.8.x once the code freeze is over.
Comment #20
alexpottDiscussed with @catch we agreed this was good to backport to 8.8.x