Is this intentional, or should i submit a patch?

CommentFileSizeAuthor
#2 3081563-2-form-field-description-before-classes.patch558 bytesmlncn

Comments

mlncn created an issue. See original summary.

mlncn’s picture

mlncn commented
StatusFileSize
new 3081563-2-form-field-description-before-classes.patch558 bytes

Well here's a patch just in case. Maybe at one point the only class added was the 'visually-hidden' one so classes weren't necessary if 'before', but now 'form-item__description' is needed for styling, so the classes need to be added (and if it is set to invisible it isn't added anyway) so in short i think this patch is good and needed :-)

Note that setting form description placement ('before' instead of 'after') or to only for screen readers ('invisible') cannot be done through the user interface yet but is part of Core's API, #314385: Make position of #description configurable via the API.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Active » Needs review

@mlncn, nice catch!

No, it isn't intentional, and thanks for the patch!

I guess this is NR.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

RTBC!

  • lauriii committed 6f03ff8 on 8.x-1.x 
    Issue #3081563 by mlncn: When a form field's description is set to...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Nice catch indeed, thank you! Committed and pushed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.