Problem/Motivation

Found at /admin/structure/block
In select elements, letters with descenders (a piece that extends below the base line) are not fully displayed

Proposed resolution

Update css to make letters fully visible

Remaining tasks

Update css, review.

User interface changes

All letters visible in select

CommentFileSizeAuthor
#5 Screenshot 2019-09-14 at 4.31.33 PM.png48.88 KBjunaidmasoodi
#4 select_list_trim-3081191-4.patch454 bytesjunaidmasoodi
chopped-descenders.png22.74 KBbnjmnm

Comments

bnjmnm created an issue. See original summary.

fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
commented
Assigned: Unassigned » fhaeberle

@bnjmnm Thanks, I'll look this up. In the meantime: Can you specify in which browser this happens?

junaidmasoodi’s picture

junaidmasoodi commented
Assigned: fhaeberle » junaidmasoodi
junaidmasoodi’s picture

junaidmasoodi commented
StatusFileSize
new select_list_trim-3081191-4.patch454 bytes

It was an issue with all browsers, Line-height for form elements was small for alphabets like 'g', 'p', 'y' etc.

junaidmasoodi’s picture

junaidmasoodi commented
StatusFileSize
new Screenshot 2019-09-14 at 4.31.33 PM.png48.88 KB

This screenshot is taken after changing line-height and testing the impact on other pages as well.

junaidmasoodi’s picture

junaidmasoodi commented
Assigned: junaidmasoodi » Unassigned
Status: Active » Needs review
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue tags: +Needs screenshots

We should cross-browser test this.

junaidmasoodi’s picture

junaidmasoodi commented
Assigned: Unassigned » junaidmasoodi
Issue tags: -Needs screenshots +Screenshot

Screengrab after resolving locally

Windows 10 IE11: https://app.crossbrowsertesting.com/public/icd427f3b0bd5d5f/livetests/28...

MacOS 10.14-Safari 12: https://app.crossbrowsertesting.com/public/icd427f3b0bd5d5f/livetests/28...

MacOS 10.14 Chrome 77:
https://app.crossbrowsertesting.com/public/icd427f3b0bd5d5f/livetests/28...

MacOS 10.14 Firefox 69:
https://app.crossbrowsertesting.com/public/icd427f3b0bd5d5f/livetests/28...

junaidmasoodi’s picture

junaidmasoodi commented
Assigned: junaidmasoodi » Unassigned

  • lauriii committed fa8701d on 8.x-1.x 
    Issue #3081191 by junaidmasoodi, bnjmnm: Select elements do not fully...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Fixed

Thank you! Seems to be working fine across all desktop browsers. Tested quickly on Android and iOS Safari to make sure they look fine as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.