Closed (fixed)
Project:
EU Cookie Compliance (GDPR Compliance)
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Sep 2019 at 14:34 UTC
Updated:
8 Nov 2020 at 18:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
maestro888 commentedComment #3
svenryen commentedThe patch needs porting to drupal 8.
Comment #4
svenryen commentedComment #5
anybodyGreat idea, this is very useful especially to keep links like imprint and other legal links in the footer menu visible with open eucc popup!
Comment #6
anybodyDrupal 8 patch attached to move things forward! The Drupal 8 version differs a bit according to differences in the D8 JS Code. For example the .css() code is much shorter in and doesn't use the body selector at all.
Comment #7
anybodyComment #8
anybodyHere we go with two new, streamlined patches for D7 and D8. To keep consistency about naming we now use "eu-cookie-compliance-popup-open" and add the body class whenever "eu_cookie_compliance_popup_open" / "eu_cookie_compliance_popup_close" are triggered.
Same code, logic and classes in D7 and D8. Please review!
Comment #9
anybodyLast but not least... final patch! In my test I found out that Drupal.eu_cookie_compliance.toggleWithdrawBanner() misses some triggers which caused that I was also missing these lines.
Addiditonally we should use the chance to add a body class to indicate if the user made a choice / set a status to allow styling and reaction accordingly. This is for example helpful to handle the toggle button or other page elements based on the users choice. Please review D8 ad D7!
BTW the automated test settings should be changed to Use latest PHP and MySQL Version plus current Drupal 8 development version. Perhaps we should also enable them for D7?
Thanks a lot!
Comment #10
dekisha commented@Anybody thanks for the patches, but unfortunately
eu-cookie-compliance-popup-openclass is not being removed when popup is closed.Comment #11
svenryen commented@dekisha Can you please provide steps to reproduce the issue you bring up in #10?
Comment #12
anybody@dekisha: I can not reproduce what you said. Are you talking about the Drupal 7 or Drupal 8 patch?
Comment #13
svenryen commentedComment #14
svenryen commentedComment #15
svenryen commentedComment #16
dekisha commented@Anybody @svenryen sorry, this was related to some other issue https://www.drupal.org/project/eu_cookie_compliance/issues/3163958
Comment #17
svenryen commented@dekisha, sorry didn't quite get you. Are you saying that you want #3163958: Position of popup is not right when collapsed in floating mode reopened and does your patch replace the one we committed or is it a follow-up patch?
Comment #18
anybody@dekisha re #16: Your patch looks unrelated to me, please create a separate issue for that if it's still a problem.
If @svenryen agrees, I'd reroll #9 against the latest dev to get this in?
Comment #19
svenryen commentedYeah, go ahead and re-roll it so we can get it in!
Comment #20
anybodyDrupal 7 reroll done! I tried the new fork feature which seems to do a good job :)
See: https://git.drupalcode.org/issue/eu_cookie_compliance-3080616/-/commit/6...
https://git.drupalcode.org/issue/eu_cookie_compliance-3080616/-/commit/6...
Drupal 8 reroll following.
Comment #21
anybodyDrupal 8 reroll done!
See https://git.drupalcode.org/issue/eu_cookie_compliance-3080616/-/commit/2...
aka https://git.drupalcode.org/issue/eu_cookie_compliance-3080616/-/commit/2...
Please review and test. :)
Comment #23
svenryen commentedComment #25
svenryen commentedThanks for the MR!