Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 8.x-1.x Comparecompare
  • 7.x-1.x Comparecompare

Comments

maestro888 created an issue. See original summary.

maestro888’s picture

Status: Active » Needs review
StatusFileSize
new3.36 KB
svenryen’s picture

The patch needs porting to drupal 8.

svenryen’s picture

Status: Needs review » Needs work
anybody’s picture

Great idea, this is very useful especially to keep links like imprint and other legal links in the footer menu visible with open eucc popup!

anybody’s picture

Status: Needs work » Needs review
Issue tags: +Needs backport to D7

Drupal 8 patch attached to move things forward! The Drupal 8 version differs a bit according to differences in the D8 JS Code. For example the .css() code is much shorter in and doesn't use the body selector at all.

anybody’s picture

anybody’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
StatusFileSize
new2.11 KB
new2.22 KB

Here we go with two new, streamlined patches for D7 and D8. To keep consistency about naming we now use "eu-cookie-compliance-popup-open" and add the body class whenever "eu_cookie_compliance_popup_open" / "eu_cookie_compliance_popup_close" are triggered.

Same code, logic and classes in D7 and D8. Please review!

anybody’s picture

Last but not least... final patch! In my test I found out that Drupal.eu_cookie_compliance.toggleWithdrawBanner() misses some triggers which caused that I was also missing these lines.

Addiditonally we should use the chance to add a body class to indicate if the user made a choice / set a status to allow styling and reaction accordingly. This is for example helpful to handle the toggle button or other page elements based on the users choice. Please review D8 ad D7!

BTW the automated test settings should be changed to Use latest PHP and MySQL Version plus current Drupal 8 development version. Perhaps we should also enable them for D7?

Thanks a lot!

dekisha’s picture

@Anybody thanks for the patches, but unfortunately eu-cookie-compliance-popup-open class is not being removed when popup is closed.

svenryen’s picture

Status: Needs review » Needs work

@dekisha Can you please provide steps to reproduce the issue you bring up in #10?

anybody’s picture

@dekisha: I can not reproduce what you said. Are you talking about the Drupal 7 or Drupal 8 patch?

svenryen’s picture

Category: Task » Feature request
svenryen’s picture

Title: Implement class "eu-cookie-compliance-popup-active" in to body » [1.x] Implement class "eu-cookie-compliance-popup-active" in to body
svenryen’s picture

Title: [1.x] Implement class "eu-cookie-compliance-popup-active" in to body » [1.x][2.0.x] Implement class "eu-cookie-compliance-popup-active" in to body
dekisha’s picture

@Anybody @svenryen sorry, this was related to some other issue https://www.drupal.org/project/eu_cookie_compliance/issues/3163958

svenryen’s picture

@dekisha, sorry didn't quite get you. Are you saying that you want #3163958: Position of popup is not right when collapsed in floating mode reopened and does your patch replace the one we committed or is it a follow-up patch?

anybody’s picture

@dekisha re #16: Your patch looks unrelated to me, please create a separate issue for that if it's still a problem.

If @svenryen agrees, I'd reroll #9 against the latest dev to get this in?

svenryen’s picture

Yeah, go ahead and re-roll it so we can get it in!

anybody’s picture

Status: Needs work » Needs review

Drupal 7 reroll done! I tried the new fork feature which seems to do a good job :)

See: https://git.drupalcode.org/issue/eu_cookie_compliance-3080616/-/commit/6...
https://git.drupalcode.org/issue/eu_cookie_compliance-3080616/-/commit/6...

Drupal 8 reroll following.

anybody’s picture

  • svenryen committed 1f94d4f on 7.x-1.x
    Issue #3080616 by Anybody, maestro888, dekisha, svenryen: [1.x][2.0.x]...
svenryen’s picture

  • svenryen committed f5bbbc4 on 8.x-1.x authored by Anybody
    Issue #3080616 by Anybody, maestro888, svenryen: [1.x][2.0.x] Implement...
svenryen’s picture

Status: Needs review » Fixed

Thanks for the MR!

  • svenryen committed 1f94d4f on 7.x-2.x
    Issue #3080616 by Anybody, maestro888, dekisha, svenryen: [1.x][2.0.x]...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.