Hello
function uc_stripe_charge() in file uc_stripe.module has unreachable code.
// Default / Fallback procedure to fail if the above conditions aren't met
$result = array(
'success' => FALSE,
'comment' => "Stripe Gateway Error",
'message' => "Stripe Gateway Error",
'uid' => $user->uid,
'order_id' => $order_id,
);
uc_order_comment_save($order_id, $user->uid, $result['message'], 'admin');
watchdog('uc_stripe', 'Stripe gateway error for order @order_id', array('order_id' => $order_id));
$_SESSION['stripe']['payment_failed'] = TRUE;
return $result;
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | uc_stripe-unreacheble-code-uc_stripe_charge-3080461-2.patch | 769 bytes | mar4ehk0 |
| uc_stripe-unreacheble-code-uc_stripe_charge.patch | 5.75 KB | mar4ehk0 |
Comments
Comment #2
andraeray commentedThanks for creating this issue and submitting a patch.
I can't commit your patch, it has too many changes unrelated to the ticket. You'll have to make sure your code matches 7.x-3.x dev branch so that the diff is clean without extra changes.
I'm going to change it form bug report, this is more like a code clean up task.
Comment #3
mar4ehk0 commentedHello AndraeRay.
I created new patch from branch 7-3.3.
Comment #4
mar4ehk0 commentedComment #5
andraeray commentedLooks good, thank you.
Comment #6
andraeray commented