Problem/Motivation

The Entity Browser replace functionality could lead to a bad UX.
So here are the steps to reproduce:

  • An existing article with a teaser image and an image paragraph is needed
  • Open the image paragraph and click the "replace" button
  • Close the EB without selecting a new image
  • Click the edit button for the teaser image
  • The EB will be opened again

Proposed resolution

Possible options:

  • Replace the "Replace" button with the "Remove" button
  • Find a patch for EB to fix that problem

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Related issues: +#2913952: modal dialog close button doesn't reset buttons that trigger modal

This might do the trick

daniel.bosen’s picture

daniel.bosen
he/him
commented

In discussion with PO, we decided to replace the replace button, instead of adding another patch, which is causing other sorts of trouble.
PR for review: https://github.com/thunder/thunder-distribution/pull/68

daniel.bosen’s picture

daniel.bosen
he/him
commented
Status: Active » Needs review

daniel.bosen credited mtodor.

daniel.bosen’s picture

daniel.bosen
he/him
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the review!

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Done

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.