Problem/Motivation

The test \Drupal\Tests\feeds\Unit\Plugin\QueueWorker\FeedRefreshTest is currently failing. This is because since Drupal 8.8 \Drupal\Core\Session\AccountProxy now requires an event dispatcher to be passed to the constructor.

Proposed resolution

In \Drupal\feeds\Plugin\QueueWorker\FeedQueueWorkerBase::switchAccount(), pass an event dispatcher as parameter when constructing an AccountProxy object.

Remaining tasks

  • Make sure tests pass on all supported D8 branches (currently D8.6 through D8.8).
  • Commit.

User interface changes

None.

API changes

None.

Data model changes

None.

Patch will follow.

CommentFileSizeAuthor
#2 feeds-fix-tests-for-d8-8-3079932-2.patch700 bytesmegachriz

Comments

MegaChriz created an issue. See original summary.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new feeds-fix-tests-for-d8-8-3079932-2.patch700 bytes
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Great, tests are passing for all three major supported branches of Drupal. Committed #2.

  • MegaChriz committed bb5a46e on 8.x-3.x 
    Issue #3079932 by MegaChriz: Fixed tests for Drupal 8.8: pass the event...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.