So, the expected mobile behavior with dropdowns in the menu is that the first touch will open the dropdown, and the second touch will visit the link.
On iOS (any browser), this works! On Android (any browser), this fails.
It seems that iOS is treating the first touch as a "hover" event, and not generating a click. On Android, it's treating the first touch as both hover and click at the same time, which visits the link right away.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | interdiff.txt | 1.25 KB | dsnopek |
| #7 | radix-android-dropdowns-3079295-7.patch | 2.93 KB | dsnopek |
Comments
Comment #2
dsnopekHere's a patch that works in my limited testing, however, it could use a lot more testing!
Comment #3
cboyden commentedTesting on a Panopoly child distribution, this fixes the first submenu level, but does not fix the next level down.
Comment #4
dsnopekI forgot (and failed to notice) that there are two completely separate code paths for the top-level dropdowns and submenus. This patch copy-paste and modifies the changes to the submenus too. This seems to be working in my testing.
Comment #5
dsnopekAnd here's and interdiff for #4 that I forgot to upload.
Comment #6
klu commentedUpdated patch works in our testing, thanks @dsnopek!
Comment #7
dsnopekAn issue was discovered with this patch where moving the mouse back-and-forth across the menus could cause the menu to "flicker", opening and closing different different dropdowns without interaction. Once this starts the only recourse is to reload the page. This is easiest to cause on Windows with Chrome, but has been done on other platforms as well. For me, if I press TAB while moving the mouse across menus, I can get it to happen really quickly.
Here's an updated patch that fixes this in my testing, but, of course, could use more testing since this is sort of tricky to make happen.
Comment #8
cboyden commentedUpdated patch works fine and no longer causes flicker on our Panopoly child distribution using a custom Radix subtheme.
Comment #10
dsnopekThanks! Committed :-)