Closed (fixed)
Project:
Scheduler
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Sep 2019 at 08:56 UTC
Updated:
19 Sep 2019 at 12:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jonathan1055 commentedHere's a patch which adds a new test file for drush. Also drush needs to be installed via a command in drupalci.yml. Also for good measure I added it into composer.json test requirements.
The new test should fail, because the fix for #3078674: Call to function runLightweightCron() on null in SchedulerCommands->cron() has not been committed yet (purposely to try this new phpunit test on drupal.org)
Comment #4
jonathan1055 commentedAs expected the new Drush test failed with
We also got the Rules test failures which are caused by patching composer.json - see #2985051: Patching composer.json shows we need to add module dependencies
Here's a patch with the cron drush fix from #3078674: Call to function runLightweightCron() on null in SchedulerCommands->cron()
Comment #5
jonathan1055 commentedTypo in composer.json
Comment #6
jonathan1055 commentedNow to see if it works with the composer change only and not the drupalci.yml commands to get drush.
Comment #7
jonathan1055 commentedSo it works fine without the container command mentioned in https://git.drupalcode.org/project/devel/blob/HEAD/drupalci.yml
Seems like having require-dev drush is in the composer.json file is sufficient.
Comment #8
jonathan1055 commentedAdded a second drush test, to check that the nodes are actually processed during the cron run.
Comment #10
jonathan1055 commentedDone.