Problem/Motivation

Support for off-canvas navbar and dropdown menus is currently hardcoded in code. This makes the implementation of client sites with very different navigation implementation difficult a bit difficult because you need to override a lot of CSS.

We should decouple off-canvas and dropdown support more so it can be disabled with current theme options.

CommentFileSizeAuthor
#8 more-navbar-decoupling-3078120-8.patch36.27 KBpivica
#8 interdiff-3078120-7-8.txt1.82 KBpivica
#7 more-navbar-decoupling-3078120-7.patch35.03 KBpivica
#6 interdiff-3078120-4-6.txt2.86 KBpivica
#6 more-navbar-decoupling-3078120-6.patch33.14 KBpivica
#5 more-navbar-decoupling-3078120-4.patch31.42 KBpivica
#4 interdiff-3078120-3-4.txt23.48 KBpivica
#4 more-navbar-decoupling-3078120-3-4.patch31.42 KBpivica
#3 more-navbar-decoupling-3078120-3.patch11.51 KBpivica
#3 interdiff-3078120-2-3.txt754 bytespivica
#2 more-navbar-decoupling-3078120-2.patch11.51 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Status: Active » Needs review
Issue tags: +next-release
StatusFileSize
new more-navbar-decoupling-3078120-2.patch11.51 KB

Here is a first patch.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3078120-2-3.txt754 bytes
new more-navbar-decoupling-3078120-3.patch11.51 KB

Fixed string concatenation for dropdown-toggle case.

pivica’s picture

pivica commented
StatusFileSize
new more-navbar-decoupling-3078120-3-4.patch31.42 KB
new interdiff-3078120-3-4.txt23.48 KB

The previous patch is introducing a nasty bug because in macro navbar_type is not defined, we need to pass it again as a variable.

Additionally, the refactoring and moving offcanvas CSS code to a new sass file exposed a new bug in drush generator - it is not handling this case correctly and leaving imports in previous SASS file which is producing duplicated CSS code now.

Moreover, a couple of smaller bugs in navbar JS code are fixed, due to extensive testing, and code is improved a bit.

Hopefully, all the problems are addressed with a new patch.

pivica’s picture

pivica commented
StatusFileSize
new more-navbar-decoupling-3078120-4.patch31.42 KB

The last patch is fine but it really has a wrong name, attaching a new one.

pivica’s picture

pivica commented
StatusFileSize
new more-navbar-decoupling-3078120-6.patch33.14 KB
new interdiff-3078120-4-6.txt2.86 KB

A New version that moves CSS needed for dropdown or horizontal to separate SASS partial so we can exclude these rules when navbar type option is off.

pivica’s picture

pivica commented
StatusFileSize
new more-navbar-decoupling-3078120-7.patch35.03 KB

Renamed newly added partial _navbar-layout to _navbar-second-level.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3078120-7-8.txt1.82 KB
new more-navbar-decoupling-3078120-8.patch36.27 KB

Let's not render off-canvas close link when offcanvase type is off. Improved off-canvas type description info for off option.

  • pivica committed e57f327 on 8.x-1.x 
    Issue #3078120 by pivica: Decouple support for navbar off-canvas and...
pivica’s picture

pivica commented
Status: Needs review » Fixed

Fixed 'off canvas' spell error, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.