Problem/Motivation

When the entity isn't a post comment "extra checks" take place. These extra checks are potentially going to load all the Group Content of the entity which can be a lot, then it's going to loop on all that loaded group content to check permissions. This can probably be done differently in a better optimised way.

Proposed resolution

Use 'break' statement to stop altering at first encounter of permission conflict for a group.

Comments

navneet0693 created an issue. See original summary.

navneet0693’s picture

Assigned: navneet0693 » Unassigned
Status: Active » Needs review
kingdutch’s picture

Status: Needs review » Needs work

See PR

navneet0693’s picture

Assigned: Unassigned » navneet0693

On it!

navneet0693’s picture

Issue summary: View changes
Status: Needs work » Needs review

Updated the PR.

jaapjan’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.