Closed (fixed)
Project:
Configuration Inspector
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Aug 2019 at 11:23 UTC
Updated:
28 Nov 2019 at 10:15 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
vuilComment #4
idebr commentedThe config inspector overview now generates a an error:
\Drupal::l()returns a string, whileLink::createFromRoute()returns an object, so you have to calltoString()on it to get a string. See https://www.drupal.org/node/2614344 for more information on this deprecation.Comment #6
vuilOh, yes. Thank you @idebr!
Update the issue solution (commit).
Comment #7
idebr commentedThis is still broken:
Link::createFromRoute()takes a route name as its second argument, but it now gets a Url object. This returns a fatal error:Comment #8
vuilComment #10
vuilThank you for the emergency notice!
I committed the new update. I already checked it twice.
Please confirm by your side.
Thank you.
Comment #11
idebr commentedNope, still broken:
Comment #12
alan-ps commentedHello, I noticed the same issue on my side. This patch should help :)
Comment #13
vuilComment #15
idebr commented#12 Thanks, the patch fixes the fatal error.
Attached patch includes a revert of the commit in #9 to fix the automated tests.
Comment #17
vuilCommitted! Thank you, guys.
Comment #19
kristen polPer a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.
Comment #20
vuil