Closed (fixed)
Project:
Contact Form Popup
Version:
8.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Reporter:
Created:
23 Aug 2019 at 09:00 UTC
Updated:
6 Jun 2020 at 19:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
patelmayank7552 commentedComment #3
purvitagupta commentedHi, here is the updated patch for coding standard.
Comment #4
purvitagupta commentedComment #5
raghavendra a m commentedHi purvitagupta, I review the contact_poup_patch.patch file. It's working fine
Comment #6
raghavendra a m commented#5 status
Comment #7
avpadernoIt's Deny access to the contact form link. (Without to is ungrammatical.)
It's on the profile page, but that means any profile page. If the users can see the link if they are on their profile page, it should be Don't display the link if the users are on their profile page.
Comment #8
purvitagupta commentedComment #9
purvitagupta commentedComment #10
avpadernoIt doesn't display the link, but it gives permission to users to see the the link. See also my previous comment.
See my previous comment.
Also, is it necessary to change code comments when the change doesn't fix coding issues?
Comment #11
Deepthi kumari commentedAttached the patch. Please review.
Comment #12
avpadernoLines should not be longer than 80 character, but this doesn't mean starting a new line after 40 characters.
Assuming the old line was too long, starting a new line is fine, but Once https://www.drupal.org/node/2724503 doesn't seem to get closer to 80 characters.
The rest of the patch is fine.
Comment #13
Deepthi kumari commentedUpdated the patch.
Comment #14
Deepthi kumari commentedComment #15
avpadernoI think it's good to go.
Comment #16
rakesh.gectcrComment #17
rakesh.gectcrThank you all for your contribution.
Comment #18
rakesh.gectcr