Hi,

Just saw that the deposit transaction only accepts rounded numbers without decimal (Integer type?).
I just tried to enter 20.50$ and I have a message telling me that the closest possible values are 20$ or 21$.
I think in most scenarios, the user who makes a deposit should be allowed to deposit the exact amount he needs to pay for something on the site, and there is only low probability that this amount would be rounded to an enire value/integer. Also, I'm not sure about the value that this constraint brings to the user or the site, knowing that all other transactions accept amounts with decimals.

Is there any good reasons for accepting only integers for deposits?
If not, is it possible to change the code to accept decimal numbers for deposit amounts?

Thanks!

CommentFileSizeAuthor
#2 3076069_deposit_amount_decimal.patch555 bytesaporie

Comments

Arno2Mars created an issue. See original summary.

aporie’s picture

Assigned: Unassigned » aporie
StatusFileSize
new555 bytes

Yeah I did it on purpose. Thinking that it was better to deposit integer amounts. But you're right it's actually more restrictive than allowing decimals. If somebody wants to implement integer amount only he will just need to alter the field.

I've set it as decimal allowed.

Patch attached.

  • Aporie committed 76bdca1 on 8.x-1.x
    Issue #3076069 by Aporie: Deposit transaction - Amount should allow...
aporie’s picture

Status: Active » Fixed
arno2mars’s picture

Thanks a lot Aporie!
As always, it works perfectly :-)

Cheers,

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.