Closed (won't fix)
Project:
Drupal core
Version:
main
Component:
Claro theme
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
20 Aug 2019 at 11:47 UTC
Updated:
20 Sep 2026 at 12:31 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Sella Durai commentedComment #3
kostyashupenkoAdded border to highlight region titles
Before patch:

After patch:

Comment #4
Sella Durai commentedthanks for your update.
Comment #5
Sella Durai commentedComment #6
Sella Durai commentedComment #7
Sella Durai commentedComment #8
Sella Durai commentedComment #9
Sella Durai commentedComment #10
Sella Durai commentedComment #11
Sella Durai commentedComment #12
Sella Durai commentedthanks for your update.
Comment #13
gisleselladurai,
thank you for engaging in the issue queues.
However, neither of you have so far not committed anything to this theme - https://www.drupal.org/node/3020054/committers , so nothing is comitted or "Fixed" here (for the record: it is one of the projects maintainers that decide whether to accept your contribution or not - this is nothing you will be able to do unless you are accepted as a co-maintainer).
And unless you are a maintainer, you should never ever set the status of an issue "Fixed". I've pushed it back to the correct status "Needs review".
At this point, I think it might be productive if you read this guide: Issue Queue Etiquette.
Comment #14
kostyashupenkoThanks for your answer @gisle
I saw this guide already, since i'm contributing into drupal from time to time already couple years. Of course @selladurai is not in the list of committers, but since i had some free time + issue was pretty clear for me + i was waiting for the answer from claro team about another issue + i had my local built up + it was really quick to suggest some improvement for this issue - i decided to put the patch + screens in case if it will be useful maybe here right now or in the future.
Comment #15
gislekostyashupenko,
my comment #13 was in no way directed at you (sorry about the word "both" - that was a copypaste-error).
I am a webmaster here and selladurai has recently requested the 'confirmed' user role. As part of our onboarding efforts, we try to mentor the users that has requested the role.
Comment #16
ckrinaHi all! Thanks for contributing!
This designs don't follow any of the design patterns of the design system we've been working on. If you feel the current design is not good enough (which still happens in a lot of places for Claro because the designs aren't finished yet) the steps should be:
1. Open an issue (you've done this, great!):
1.1. Update the issue summary with the necessary info. For doing so you could follow the pattern used in several other issues, like #3023319: Card Style Update where several clear headings are properly explained: Problem/Motivation/ Proposed solution and ideally provide (and embed) screenshots. I've added the pattern for you, please fill the corresponding sections that apply :)
2. Wait for feedback. You (sometimes) can accelerate this by mentioning on the #admin-ui channel on Drupal Slack, but please take into account that the maintainers won't always be available.
For this specific case, you're implementing some design changes (adding black lines on tables for what I see on the screenshots) that have not being approved on the design system. You could suggest your changes or your needs on the #admin-ui-design channel on Drupal Slack or mark an issue with the Claro specific component Needs design and we'll work on this and will suggest a design later on.
I'm adding the tag "Needs issue summary update" so you can improve the description of this issue and postponing until teh design solution is clear. I'm also changing the component to Needs design. And don't mark things with priority Major if you're not sure they are :)
Comment #17
ckrinaComment #18
Sella Durai commentedComment #19
huzookaComment #20
Sella Durai commentedComment #21
ckrinaComment #30
quietone commentedThe Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.
The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.
Comment #31
smustgrave commentedActually going to close this one out. It was requested by maintainer of claro for summary update and/or designs but summary seems empty.