Problem/Motivation

need to work onadmin>structure> block layout >claro for the heading tags need some border it looks good.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

selladurai created an issue. See original summary.

Sella Durai’s picture

kostyashupenko’s picture

Status: Active » Needs review
StatusFileSize
new553 bytes
new119.99 KB
new119.51 KB

Added border to highlight region titles

Before patch:
Before patch

After patch:
Before patch

Sella Durai’s picture

Status: Needs review » Fixed

thanks for your update.

Sella Durai’s picture

Sella Durai’s picture

Sella Durai’s picture

Sella Durai’s picture

Sella Durai’s picture

Sella Durai’s picture

Sella Durai’s picture

Sella Durai’s picture

thanks for your update.

gisle’s picture

Status: Fixed » Needs review

selladurai,
thank you for engaging in the issue queues.

However, neither of you have so far not committed anything to this theme - https://www.drupal.org/node/3020054/committers , so nothing is comitted or "Fixed" here (for the record: it is one of the projects maintainers that decide whether to accept your contribution or not - this is nothing you will be able to do unless you are accepted as a co-maintainer).

And unless you are a maintainer, you should never ever set the status of an issue "Fixed". I've pushed it back to the correct status "Needs review".

At this point, I think it might be productive if you read this guide: Issue Queue Etiquette.

kostyashupenko’s picture

Thanks for your answer @gisle

I saw this guide already, since i'm contributing into drupal from time to time already couple years. Of course @selladurai is not in the list of committers, but since i had some free time + issue was pretty clear for me + i was waiting for the answer from claro team about another issue + i had my local built up + it was really quick to suggest some improvement for this issue - i decided to put the patch + screens in case if it will be useful maybe here right now or in the future.

gisle’s picture

kostyashupenko,
my comment #13 was in no way directed at you (sorry about the word "both" - that was a copypaste-error).

I am a webmaster here and selladurai has recently requested the 'confirmed' user role. As part of our onboarding efforts, we try to mentor the users that has requested the role.

ckrina’s picture

Component: User interface » Needs design
Priority: Major » Normal
Status: Needs review » Postponed
Issue tags: +Needs issue summary update

Hi all! Thanks for contributing!

This designs don't follow any of the design patterns of the design system we've been working on. If you feel the current design is not good enough (which still happens in a lot of places for Claro because the designs aren't finished yet) the steps should be:

1. Open an issue (you've done this, great!):
1.1. Update the issue summary with the necessary info. For doing so you could follow the pattern used in several other issues, like #3023319: Card Style Update where several clear headings are properly explained: Problem/Motivation/ Proposed solution and ideally provide (and embed) screenshots. I've added the pattern for you, please fill the corresponding sections that apply :)
2. Wait for feedback. You (sometimes) can accelerate this by mentioning on the #admin-ui channel on Drupal Slack, but please take into account that the maintainers won't always be available.

For this specific case, you're implementing some design changes (adding black lines on tables for what I see on the screenshots) that have not being approved on the design system. You could suggest your changes or your needs on the #admin-ui-design channel on Drupal Slack or mark an issue with the Claro specific component Needs design and we'll work on this and will suggest a design later on.

I'm adding the tag "Needs issue summary update" so you can improve the description of this issue and postponing until teh design solution is clear. I'm also changing the component to Needs design. And don't mark things with priority Major if you're not sure they are :)

ckrina’s picture

Issue summary: View changes
Sella Durai’s picture

Assigned: Unassigned » Sella Durai
Issue tags: +IttHackathon
huzooka’s picture

Project: Claro » Drupal core
Version: 8.x-1.x-dev » 8.9.x-dev
Component: Needs design » Claro theme
Sella Durai’s picture

ckrina’s picture

Issue tags: +Needs design

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

Assigned: Sella Durai » Unassigned

The Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.

The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.

smustgrave’s picture

Status: Postponed » Closed (won't fix)

Actually going to close this one out. It was requested by maintainer of claro for summary update and/or designs but summary seems empty.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.