drupal-check docroot/themes/contrib/vartheme_admin

1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------- 
  Line   vartheme_admin.theme                                                      
 ------ -------------------------------------------------------------------------- 
  28     Call to deprecated function drupal_get_profile():                         
         in drupal:8.3.0 and is removed from drupal:9.0.0.                         
         Use the install_profile container parameter or \Drupal::installProfile()  
         instead. If you are accessing the value before it is written to           
         configuration during the installer use the $install_state global. If you  
         need to access the value before container is available you can use        
         BootstrapConfigStorageFactory to load the value directly from             
         configuration.                                                            
  30     Call to deprecated function drupal_get_profile():                         
         in drupal:8.3.0 and is removed from drupal:9.0.0.                         
         Use the install_profile container parameter or \Drupal::installProfile()  
         instead. If you are accessing the value before it is written to           
         configuration during the installer use the $install_state global. If you  
         need to access the value before container is available you can use        
         BootstrapConfigStorageFactory to load the value directly from             
         configuration.                                                            
  31     Call to deprecated function drupal_get_profile():                         
         in drupal:8.3.0 and is removed from drupal:9.0.0.                         
         Use the install_profile container parameter or \Drupal::installProfile()  
         instead. If you are accessing the value before it is written to           
         configuration during the installer use the $install_state global. If you  
         need to access the value before container is available you can use        
         BootstrapConfigStorageFactory to load the value directly from             
         configuration.                                                            
  34     Call to deprecated function drupal_get_profile():                         
         in drupal:8.3.0 and is removed from drupal:9.0.0.                         
         Use the install_profile container parameter or \Drupal::installProfile()  
         instead. If you are accessing the value before it is written to           
         configuration during the installer use the $install_state global. If you  
         need to access the value before container is available you can use        
         BootstrapConfigStorageFactory to load the value directly from             
         configuration.                                                            
 ------ -------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 4 errors


Upgrade status



Drupal coding standard and Drupal Practice check should pass

PHPCS, PHPCBF for both --standard=Drupal and --standard=DrupalPractice

Check Vartheme Admin Drupal coding standard

phpcbf --standard=Drupal --extensions=php,inc,install,test,profile,theme,scss,css,info,txt,md /var/www/html/products/vartheme_admin/ --ignore="/var/www/html/products/vartheme_admin/node_modules/"

phpcs --standard=Drupal --extensions=php,inc,install,test,profile,theme,scss,css,info,txt,md /var/www/html/products/vartheme_admin/ --ignore="/var/www/html/products/vartheme_admin/node_modules/"

Check Vartheme Admin Drupal Practice

phpcbf --standard=DrupalPractice --extensions=php,inc,install,test,profile,theme,scss,css,info,txt,md /var/www/html/products/vartheme_admin/ --ignore="/var/www/html/products/vartheme_admin/node_modules/"

phpcs --standard=DrupalPractice --extensions=php,inc,install,test,profile,theme,scss,css,info,txt,md /var/www/html/products/vartheme_admin/ --ignore="/var/www/html/products/vartheme_admin/node_modules/"
CommentFileSizeAuthor
#2 deprecated-3075974-2.patch1.15 KBsergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

Status: Active » Needs review
StatusFileSize
new1.15 KB

Please review.

rajab natshah’s picture

Title: Deprecated Code Report » Deprecated Code Report in Drupal 9 and Drupal 8.8.x only
Status: Needs review » Postponed

#2958925: Properly deprecate drupal_get_profile()
Postponed until Drupal 8.8.0 stable is out
It did not work with Drupal 8.7.10

rajab natshah’s picture

Status: Postponed » Active
rajab natshah’s picture

Title: Deprecated Code Report in Drupal 9 and Drupal 8.8.x only » Drupal 9 Readiness for [Vartheme Admin] with Drupal coding standard and practice
Issue summary: View changes
rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes

  • RajabNatshah committed 106a979 on 8.x-6.x
    Issue #3075974: Drupal 9 Readiness for [Vartheme Admin] with Drupal...
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Status: Active » Needs review
Issue tags: +varbase-8.8.4, +varbase-8.9.0, +varbase-9.0.0
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Assigned: Unassigned » rajab natshah
Status: Fixed » Needs work

Warning on install !!!

User warning: The following profile is missing from the file system: in drupal_get_filename() (line 295 of core/includes/bootstrap.inc).
drupal_get_filename('profile', NULL) (Line: 314)
drupal_get_path('profile', NULL) (Line: 31)
vartheme_admin_preprocess_install_page(Array, 'install_page', Array) (Line: 287)
rajab natshah’s picture

If you are accessing the value before it is written to configuration during the installer use the $install_state global.

https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/functi...

Deprecated

in drupal:8.3.0 and is removed from drupal:9.0.0. Use the install_profile container parameter or \Drupal::installProfile() instead. If you are accessing the value before it is written to configuration during the installer use the $install_state global. If you need to access the value before container is available you can use BootstrapConfigStorageFactory to load the value directly from configuration.

  • RajabNatshah committed bd25311 on 8.x-6.x
    Issue #3075974: Drupal 9 Readiness for [Vartheme Admin] with Drupal...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Needs work » Needs review
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue tags: -varbase-9.0.0 +varbase-9.1.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Title: Drupal 9 Readiness for [Vartheme Admin] with Drupal coding standard and practice » Drupal 9 compatibility for [Vartheme Admin] with Drupal coding standard and practice
Issue tags: -Drupal 9 readiness, -varbase-8.9.0
rajab natshah’s picture

Issue tags: -varbase-9.1.0