Enable/disable for specific content types

Any updates on this issue?

Here's a patch & test for this.

Updated patch.

This functionality is important for us as well; we have a couple of our content types that should not be cloned, where everything else should. A developer on my team is trying this patch, and should update here after it's tested.

It seems work, but coding standards show error (Class name doesn't match filename; expected "class QuickNodeCloneAllowedBundlesTest"). The updated patch can fix this issue. I haven't done Kernel test, but it should be working.

I hadn't realized that there were permissions that control this. In theory, the only reason you'd need this patch is if you want to disable cloning for users with the administrator role, which automatically gets all the permissions.

I re-rolled the patch #8 and made a merge request.

Posting patch here, so it can be used with composer patches

Re-roll

Tested #16 and works fine

I tested #16 and it works fine.

#16 was no longer applying cleanly since the inclusion of #3334865: Make support for groups optional. We need the latest changes to be in an MR so that tests will run so I created a new branch with the changes from #16 adjusted so that they would apply.

After applying MR#30 to 8.x-1.x-dev, I get the following error.

Error message
Warning: foreach() argument must be of type array|object, null given in Drupal\Core\Render\Element\Checkboxes::valueCallback() (line 113 of core/lib/Drupal/Core/Render/Element/Checkboxes.php).

Drupal\Core\Render\Element\Checkboxes::valueCallback(Array, , Object)
call_user_func_array(Array, Array) (Line: 1285)
Drupal\Core\Form\FormBuilder->handleInputElement('quick_node_clone_node_setting_form', Array, Object) (Line: 1006)
Drupal\Core\Form\FormBuilder->doBuildForm('quick_node_clone_node_setting_form', Array, Object) (Line: 1076)
Drupal\Core\Form\FormBuilder->doBuildForm('quick_node_clone_node_setting_form', Array, Object) (Line: 579)
Drupal\Core\Form\FormBuilder->processForm('quick_node_clone_node_setting_form', Array, Object) (Line: 325)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 627)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 53)
Asm89\Stack\Cors->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

MR#30 seems to work great for 8.x-1.19

I tried using AccessResult::forbidden(), but other checks are not performed if a user has 'bypass node access'.

I think we can use hook_link_alter to remove the 'Clone' task.