1. Add a configurable textarea with each action to ask message for slack notification
  2. Text area should be hidden by default. When a user select any action, its respective textarea should be visible and should be required.
  3. Each textarea should have a default message which is hard coded right now.
  4. Textarea should have support of tokens (default tokens and node tokens) as well.
CommentFileSizeAuthor
#12 configurable_text_actions-3075817-12.patch4.94 KBpallavisk
#9 configurable_text_actions-3075817-09.patch4.8 KBpallavisk
#4 configurable_text-3075817-04.patch4.74 KBpallavisk
#2 3075817_1.patch2.33 KBpallavisk

Comments

sumitmadan created an issue. See original summary.

pallavisk’s picture

pallavisk commented
StatusFileSize
new 3075817_1.patch2.33 KB
Lal_’s picture

Lal_
He\Him
commented
Status: Active » Needs review
pallavisk’s picture

pallavisk commented
StatusFileSize
new configurable_text-3075817-04.patch4.74 KB

1.Added configurable textarea for each action.
2.On basis of selection, respective text area is hidden/visible.
3.Default message for each text area.
4. Support of tokens executed.

pallavisk’s picture

pallavisk commented
StatusFileSize
new configurable_text_for_actions-3075817-05.patch4.66 KB

Typo fixed.

Lal_’s picture

Lal_
He\Him
commented

@pallavisk good work on the patch, it applies fine.

Lal_’s picture

Lal_
He\Him
commented
Status: Needs review » Reviewed & tested by the community
Lal_’s picture

Lal_
He\Him
commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new configurable_text-3075817-04.patch4.74 KB

oops..

+++ b/src/Form/SettingsForm.php
@@ -66,12 +66,26 @@ class SettingsForm extends ConfigFormBase {
+        '#required' => TRUE,

what happens if the don't select the field, still I have to unhide it and add the value to it.

pallavisk’s picture

pallavisk commented
StatusFileSize
new configurable_text_actions-3075817-09.patch4.8 KB

I have updated the patch.

Lal_’s picture

Lal_
He\Him
commented
Status: Needs work » Reviewed & tested by the community

good fix

Lal_’s picture

Lal_
He\Him
commented
Status: Reviewed & tested by the community » Needs work

Oops again :-) I am seeing coding standard errors.. please run phpcbf --standard=drupal <path>

pallavisk’s picture

pallavisk commented
StatusFileSize
new configurable_text_actions-3075817-12.patch4.94 KB
pallavisk’s picture

pallavisk commented
Lal_’s picture

Lal_
He\Him
commented
Status: Needs work » Reviewed & tested by the community

Looks good

Lal_’s picture

Lal_
He\Him
commented
Lal_’s picture

Lal_
He\Him
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.